Open v0y4g3r opened 1 year ago
I want to try this issues.
@WangTingZheng hello, are u still working on this feature?
@WangTingZheng hello, are u still working on this feature?
I'm sorry, I may not have enough time to complete this task recently.
@WangTingZheng That's fine. So may I assign this task to other developers? Thank u.
We are refactoring the mito
table engine and the implementation hint in the description will soon become outdated. So I self-assign this task first.
See the implementation of the Kafka Remote Wal #2722 .
What problem does the new feature solve?
Not all tables require durability at the cost of insert throughput. With periodical table flush, losing a short period of data in memtable is acceptable in some scenarios.
What does the feature do?
Allow user to specify whether to skip writing WAL on data ingestion.
Implementation challenges
Add a table option on creation, maybe
skip_wal
. Inwrite_to_wal
, check if this table should skip WAL. https://github.com/GreptimeTeam/greptimedb/blob/b31a6cb506c5fd4cee417ddb3c0780d25272b505/src/storage/src/wal.rs#L103-L113If
skip_wal
is true, simply return the sequence number as entry id without actually writing to underlying log store.