GreptimeTeam / greptimedb

An open-source, cloud-native, unified time series database for metrics, logs and events with SQL/PromQL supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
4.23k stars 303 forks source link

Check NULL value in multi-fields PromQL case #1378

Open waynexia opened 1 year ago

waynexia commented 1 year ago

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

As @sunng87 figured out in https://github.com/GreptimeTeam/greptimedb/pull/1362/files#r1165177284.

The current implementation and test don't cover when a NULL exists in multi-fields table. It may cause runtime panic during execution.

Implementation challenges

No response

killme2008 commented 1 year ago

@waynexia Please take a look