search

GreptimeTeam / greptimedb

An open-source, cloud-native, unified time series database for metrics, logs and events with SQL/PromQL supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
4.19k stars 300 forks source link

It is recommended to support decimal and enum type,and so on. #1947

Open daheige opened 1 year ago

daheige commented 1 year ago

What problem does the new feature solve?

image

Take a look at the currently supported data types. For the MySQL protocol, it is still necessary to support the decimal type for the type of financial calculation, because the accuracy of the float type cannot meet the calculation and processing of financial currencies. In addition, for the enumeration type, some companies are also using it. Can greptimedb support this type?

Other mysql types:

image

What does the feature do?

Support decimal type for currency calculation and enum type,and so on.

Implementation challenges

No response

killme2008 commented 1 year ago

Sorry, the document is not updated to date. The blob type is already supported in #1818 .

Supporting decimal is a great idea, it's helpful in high-precision calculation. It's supported by Arrow too.

Other types such as bool is useful too, i think we can support it.

The set and enum is not in common usage, and we want to support the json type in future, so maybe their priorities are lower.

daheige commented 1 year ago

oh oh,I understand. Thank you for your reply. For the types of decimal json(mysql8.0+ version support it) bool enum that MySQL already has, it is still recommended to support them. I would like to emphasize here that although enum can use int type or varchar support, users who are accustomed to enum still hope that you can consider it. The main purpose of these types of designs mentioned above is to facilitate the smooth transition of MySQL users' companies to greptimedb.

------------------ Original ------------------ From: dennis zhuang @.> Date: Thu,Jul 20,2023 0:26 AM To: GreptimeTeam/greptimedb @.> Cc: heige @.>, Author @.> Subject: Re: [GreptimeTeam/greptimedb] It is recommended to support decimaland enum type,and so on. (Issue #1947)

Sorry, the document is not updated to date. The blob type is already supported in #1818 .

Supporting decimal is a great idea, it's helpful in high-precision calculation. It's supported by Arrow too.

Other types such as bool is useful too, i think we can support it.

The set and enum is not in common usage, and we want to support the json type in future, so maybe their priorities are lower.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>