Upgrade Axum to 0.7 - Githubissues

GreptimeTeam / greptimedb

An open-source, cloud-native, unified time series database for metrics, logs and events with SQL/PromQL supported. Available on GreptimeCloud.

https://greptime.com/

Apache License 2.0

4.33k stars 313 forks source link

Upgrade Axum to 0.7 #3610

Open tisonkun opened 7 months ago

tisonkun commented 7 months ago

What type of enhancement is this?

Tech debt reduction, Other

What does the enhancement do?

Sooner or later we should upgrade it. I'd create this ticket to collect information, since this upgrade is a huge breaking changes from axum side - https://github.com/tokio-rs/axum/releases/tag/axum-v0.7.0

Implementation challenges

No response

tisonkun commented 7 months ago

Blocked by tonic uses http 0.2 and axum 0.6.

Ref - https://github.com/hyperium/tonic/pull/1595

tisonkun commented 7 months ago

Other refs -

yurivict commented 6 months ago

What is holding this?

tisonkun commented 6 months ago

@yurivict This is mainly blocked by https://github.com/hyperium/tonic/pull/1670.

tisonkun commented 4 months ago

tonic 0.12 has been released. We can move forward now.

tisonkun commented 4 months ago

substrait's prost version needs bump also.

tisonkun commented 4 months ago

greptime-proto's patch - https://github.com/GreptimeTeam/greptime-proto/pull/181

tisonkun commented 4 months ago

Blocked by

I'm afraid that we cannot upgrade until September's Arrow & DataFusion release and we catch up to it.

I don't know if the upgrade can be done separated, but at least cannot as a whole.

cc @waynexia @MichaelScofield

shuiyisong commented 1 month ago

Some updates on this issue. Arrow and Dafafusion have both merged the corresponding PR. We'll wait for our dependency on Arrow to be updated to v53 and then we can start doing the upgrade.

cc @waynexia

Ref

waynexia commented 1 month ago

💯 I'm preparing the migration to arrow 53 and the latest datafusion