search

GreptimeTeam / greptimedb

An open-source, cloud-native, distributed time-series database with PromQL/SQL/Python supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
3.97k stars 283 forks source link

Support TLS reloading on gRPC server #4104

Open shuiyisong opened 1 month ago

shuiyisong commented 1 month ago

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

previous: https://github.com/GreptimeTeam/greptimedb/issues/3336

We've support configuring TLS on gRPC server, but the auto reload is not supported yet, and it's inconsistency with MySQL and PostgreSQL server.

https://github.com/GreptimeTeam/greptimedb/blob/297105266b3ddc29d685d084d81f8b4404989516/src/servers/src/grpc/builder.rs#L170-L175

Let's enable auto reloading on gRPC server too.

Implementation challenges

No response

irenjj commented 1 month ago

I'd like to take it.

shuiyisong commented 1 month ago

I'd like to take it.

Have fun 🤩

irenjj commented 4 weeks ago

hi, @shuiyisong , it seems for tonic based gRPC, reloading TLS config requires restarting the service

shuiyisong commented 3 weeks ago

@irenjj OK, it's more complicated then I originally thought. We'll dig into this problem later. Removing you from assignees from now, but you are always free to explore this problem. :P