search

GreptimeTeam / greptimedb

An open-source, cloud-native, unified time series database for metrics, logs and events with SQL/PromQL supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
4.23k stars 303 forks source link

feat: bulk memtable codec #4163

Closed v0y4g3r closed 3 months ago

v0y4g3r commented 3 months ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Introduce bulk memtable encoder/decoder.

Checklist

Summary by CodeRabbit

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 82.87037% with 111 lines in your changes missing coverage. Please review.

Project coverage is 84.79%. Comparing base (5566dd7) to head (2e6656e). Report is 12 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4163 +/- ## ========================================== - Coverage 85.06% 84.79% -0.27% ========================================== Files 1028 1034 +6 Lines 180477 182435 +1958 ========================================== + Hits 153514 154697 +1183 - Misses 26963 27738 +775 ```
WenyXu commented 3 months ago

@coderabbitai review

coderabbitai[bot] commented 3 months ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot] commented 3 months ago

Walkthrough

The updates introduce several new functionalities to the mito2 project, focusing on handling bulk data. Key changes include adding new error variants, enhancing memtable capabilities with bulk operations, defining structures for encoding/decoding bulk parts, and modifying the visibility of certain struct fields. These updates aim to improve data handling efficiency, particularly for bulk operations, and standardize error handling.

Changes

File(s) Change Summary
src/mito2/src/error.rs Added UnsupportedOperation variant to Error enum and mapped it to StatusCode::Unsupported.
src/mito2/src/memtable.rs, .../memtable/partition_tree.rs, .../time_series.rs Introduced BulkPart struct and write_bulk method for memtables, with placeholders for unsupported bulk writes in some memtable implementations.
src/mito2/src/memtable/bulk.rs, .../memtable/bulk/part.rs Implemented BulkMemtable and bulk part handling with encoding and decoding functions.
src/mito2/src/memtable/key_values.rs Modified visibility of mutation field in KeyValues and added KeyValuesRef struct for iterating key-value pairs.
src/mito2/src/row_converter.rs Added new_with_primary_keys method to McmpRowCodec for initializing codecs with primary keys.
src/mito2/src/sst.rs Added functions to generate Arrow schema for Parquet storage and define internal fields.
src/mito2/src/sst/parquet.rs Made format module public.
/test_util/memtable_util.rs Added write_bulk method to EmptyMemtable.
new in src/mito2/src/memtable/bulk/part.rs Introduced bulk part encoding/decoding, mutation to Arrow record batch conversion, and various utility functions.

Poem

Amid the code and bytes we tread, Bulk data flows where once we dread. Memtables wrote with eager haste, Errors now with proper grace. BulkPart stands robust and tall, Encoding mutations, catching all. Cheers to progress, lines so neat, A coder's job is now complete! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
v0y4g3r commented 3 months ago

PTAL @evenyag @WenyXu @waynexia

v0y4g3r commented 3 months ago

@WenyXu PTAL