fix(flow): fix call df func bug&sqlness test

discord9 commented 4 weeks ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

fix a bug when calling df func like abs while nested some flow's own function like abs(sum(number)), and also added some sqlness tests

Please explain IN DETAIL what the changes are in this PR and why they are needed:

fix a bug which fail to parse case like abs(sum(number))
add unit tests for that case
add sqlness tests for flow

Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

New Features
- Added SQL operations for creating tables, defining flows, inserting data, querying data with time windows, and dropping tables.
Bug Fixes
- Ensured consistency in column name formatting by modifying capitalization from uppercase to lowercase.
Improvements
- Enhanced WorkerHandle shutdown process with better error handling and logging.
- Introduced auto_columns to signify non-auto columns in table schemas.
- Updated DataFrame function tests to include basic and expression tree tests.
Dependency Updates
- Upgraded sqlness dependency version from 0.5 to 0.6.1.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 92.46704% with 40 lines in your changes missing coverage. Please review.

Project coverage is 84.81%. Comparing base (5566dd7) to head (fa89509).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4165 +/- ## ========================================== - Coverage 85.06% 84.81% -0.25% ========================================== Files 1028 1028 Lines 180477 180845 +368 ========================================== - Hits 153514 153383 -131 - Misses 26963 27462 +499 ```

coderabbitai[bot] commented 3 weeks ago

[!WARNING]

Rate limit exceeded

@discord9 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 19 seconds before requesting another review.

How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.

Commits
Files that changed from the base of the PR and between 768ffcf053d552e8b0bece8676a72ebbfbb407a1 and fa89509b7966b5f9a86f4440568f44eadeec777e.

Walkthrough

Recent changes enhance the FlownodeManager by standardizing column names to lowercase and improve the TableSource with a new auto_columns feature. Significant updates in WorkerHandle handling and test optimizations, as well as enriched expressions in scalar.rs, relation.rs, and plan.rs files, bolster functionality and testing. Additionally, SQL operations were added to the tests, and the sqlness dependency was updated. These refinements collectively promote consistency, error handling, and code robustness.

Changes

File(s)	Summary
`src/.../adapter.rs`	Modified column name formatting to lowercase in `FlownodeManager`.
`src/.../adapter/table_source.rs`	Introduced `auto_columns` to signify non-auto columns in `TableSource`.
`src/.../adapter/worker.rs`	Updated `drop` method to use `block_on` for `WorkerHandle` and adjusted tests accordingly.
`src/.../expr/scalar.rs`	Enhanced support for expressions and evaluation functions, including comment updates and new methods.
`src/.../repr/relation.rs`	Added `auto_columns` to `RelationType` and adjusted `RelationDesc` with error handling for field length mismatch.
`src/.../transform/aggr.rs`	Added logic for marking auto-added columns and extended DataFrame function tests.
`src/.../transform/expr.rs`	Introduced `proto_col` function and refactored existing functions to improve expression handling.
`src/.../transform/plan.rs`	Refined `from_substrait_rel` method and added methods to handle projects, filters, and reads.
`tests/cases/.../flow/basic.result`	Added SQL operations for table creation, data manipulation, flow definition, and querying.
`tests/cases/.../flow/df_func.result`	Added SQL operations for tables and flows using DataFrame functions and absolute sums.
`tests/runner/Cargo.toml`	Updated `sqlness` dependency version from `"0.5"` to `"0.6.1"`.

A bunny hopped through fields of code, With agile paws, it lightened the load. From capital columns, lowercase leapt, Auto columns marked, promises kept. Dependencies grew, tighter they bound, In SQL flows, new strengths were found. 🐇✨💻

This summary encapsulates the file-specific changes and includes a whimsical poem to celebrate the improvements.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

GreptimeTeam / greptimedb