search

GreptimeTeam / greptimedb

An Open-Source, Cloud-Native, Unified Time Series Database for Metrics, Events, and Logs with SQL/PromQL supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
4k stars 289 forks source link

refactor: migrate region failover implementation to region migration #4172

Closed WenyXu closed 3 weeks ago

WenyXu commented 4 weeks ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

4161

What's changed and what's your intention?

Migrate region failover implementation to region migration

Checklist

Summary by CodeRabbit

WenyXu commented 3 weeks ago

@coderabbitai review

coderabbitai[bot] commented 3 weeks ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot] commented 3 weeks ago

Walkthrough

The recent changes involve extensive updates in the meta and meta-srv modules. These updates include removing unused and deprecated modules, introducing a view_info module, enhancing error handling, improving region failure detection and supervision, refactoring region migration functionality, and adding utility functions for testing.

Changes

File/Path Change Summary
src/common/meta/src/key.rs Removed unused modules; added view_info module.
src/meta-srv/src/error.rs Added LookupPeer variant to Error enum for peer lookup failures.
src/meta-srv/src/failure_detector.rs Implemented RegionFailureDetector module for detecting region failures.
src/meta-srv/src/handler/failure_handler.rs Restructured RegionFailureHandler and updated implementations.
src/meta-srv/src/metasrv.rs Added region_supervisor_ticker field and related methods.
src/meta-srv/src/metasrv/builder.rs Introduced RegionSupervisor and refined region failover handling logic.
src/meta-srv/src/procedure.rs Added TODO comment; allowed unused region_failover module.
src/meta-srv/src/procedure/region_migration.rs Modified RegionMigrationProcedure struct; added new fields and methods.
src/meta-srv/src/procedure/region_migration/manager.rs Refactored procedures to use RegionMigrationProcedureTracker.
src/meta-srv/src/procedure/region_migration/test_util.rs Enhanced TestingEnv with new fields and methods; adjusted visibility.
src/meta-srv/src/region.rs Added failure_detector and supervisor modules.
src/meta-srv/src/region/failure_detector.rs Detailed implementation for managing region failure detectors.
src/meta-srv/src/region/supervisor.rs Introduced RegionSupervisor for failure detection and state management.
src/meta-srv/src/selector.rs Added test_utils module for test context creation.
src/meta-srv/src/selector/test_utils.rs Created functions and structures for testing node selection.
src/meta-srv/src/test_util.rs Removed create_region_failover_manager function and related dependencies.

Poem

"In the code, we weave and clear, Modules gone, and updates near. Supervisors watch with keen eye, Regions fail, but we still try. Tracking peers, handling fears, Upholding the code—cheers! 🐰✨"

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 68.73857% with 171 lines in your changes missing coverage. Please review.

Project coverage is 84.62%. Comparing base (a1e2612) to head (25eb3c9). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4172 +/- ## ========================================== - Coverage 85.11% 84.62% -0.49% ========================================== Files 1031 1039 +8 Lines 181828 182758 +930 ========================================== - Hits 154759 154657 -102 - Misses 27069 28101 +1032 ```
WenyXu commented 3 weeks ago

@coderabbitai The sequence diagrams is incorrect, please re-generate it.

coderabbitai[bot] commented 3 weeks ago

[!TIP] For best results, initiate chat on the files or code changes.

@WenyXu, to regenerate the correct sequence diagram, could you please specify which part of the system or process the diagram represents? Additionally, if there are specific files or documentation where this diagram is mentioned, that would be very helpful. This will ensure that the regenerated diagram accurately reflects the intended interactions.