GreptimeTeam / greptimedb

An Open-Source, Cloud-Native, Unified Time Series Database for Metrics, Events, and Logs with SQL/PromQL supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
4k stars 289 forks source link

fix: region logical regions after catching up #4176

Closed WenyXu closed 3 weeks ago

WenyXu commented 3 weeks ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR registers metric logical regions after invoking catchup and fixes metric logical regions not found issues after migrating a physical region.

After replaying the WAL of a metric metadata region, there are two places required to register logical regions manually:

Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.86%. Comparing base (4306cba) to head (e986c0c). Report is 5 commits behind head on main.

:exclamation: Current head e986c0c differs from pull request most recent head 62b886d

Please upload reports for the commit 62b886d to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4176 +/- ## ========================================== - Coverage 85.12% 84.86% -0.27% ========================================== Files 1022 1022 Lines 179843 179859 +16 ========================================== - Hits 153094 152631 -463 - Misses 26749 27228 +479 ```
killme2008 commented 3 weeks ago

@WenyXu Please describe the PR in detail. What issue does it address? What happened before this patch etc.