search

GreptimeTeam / greptimedb

An Open-Source, Cloud-Native, Unified Time Series Database for Metrics, Events, and Logs with SQL/PromQL supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
4k stars 289 forks source link

feat: heartbeat task&peer lookup in proc #4179

Closed discord9 closed 3 weeks ago

discord9 commented 3 weeks ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

added heartbeat&peer lookup, allowing flow to register to metasrc& using flownode in procedure

Summary by CodeRabbit

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 29.48718% with 165 lines in your changes missing coverage. Please review.

Project coverage is 84.75%. Comparing base (5566dd7) to head (2ba19a9). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4179 +/- ## ========================================== - Coverage 85.06% 84.75% -0.31% ========================================== Files 1028 1030 +2 Lines 180477 181069 +592 ========================================== - Hits 153514 153462 -52 - Misses 26963 27607 +644 ```
coderabbitai[bot] commented 3 weeks ago

Walkthrough

The recent updates introduce significant enhancements across various modules, focusing on peer lookup mechanisms, error handling, and heartbeat functionalities. Notably, a StandalonePeerLookupService is now woven into many components to streamline peer management. Additionally, a new heartbeat functionality ensures robust communication between flownodes and the metasrv server. These changes collectively improve error handling, peer lookup consistency, and the overall robustness of the system's network communication.

Changes

Files Change Summaries
src/cmd/.../standalone.rs Added peer_lookup_service with StandalonePeerLookupService in the StartCommand implementation.
src/common/meta/.../drop_flow.rs Introduced OptionExt for improved error handling and modified Peer creation in DropFlowProcedure.
src/common/meta/.../ddl_manager.rs Added StandalonePeerLookupService to the Peer import and included peer_lookup_service field.
src/common/meta/.../peer.rs Imported Arc and Error, declared new types and traits like PeerLookupService and StandalonePeerLookupService.
src/common/meta/.../test_util.rs Initialized peer_lookup_service with StandalonePeerLookupService in new_ddl_context_with_kv_backend.
src/flow/.../heartbeat.rs Introduced HeartbeatTask struct for sending heartbeat messages to the metasrv server.
src/meta-srv/.../lease.rs Modified peer lookup functions, introduced lease durations, and added MetaPeerLookupService.
src/meta-srv/.../metasrv.rs Replaced lookup_alive_datanode_peer with lookup_datanode_peer and updated method parameters.
src/meta-srv/.../procedure/utils.rs Imported StandalonePeerLookupService and initialized peer_lookup_service.
tests-integration/.../standalone.rs Initialized peer_lookup_service with StandalonePeerLookupService in GreptimeDbStandaloneBuilder.

Poem

In the realm of code, where bytes do dance,
A new peer service takes its chance.
Heartbeats whisper, nodes align,
Error handling now so fine.
Lookups swift, in clusters roam,
Hail to changes, our new home. 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.