Closed zyy17 closed 3 months ago
Attention: Patch coverage is 75.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 84.77%. Comparing base (
5566dd7
) to head (4d99fd1
).
@evenyag @WenyXu I have removed Serialize
and Deserialize
from PickerOutput
and add the new modification of making RegionOptions
serializable. PTAL.
@coderabbitai review
The changes primarily introduce the Serialize
trait from serde
to various structs and enums within the compactor.rs
and options.rs
files in the mito2
module. This enables these types to be serialized, improving their usability for data interchange. The core modifications include updating the MergeOutput
struct and several structs and enums related to region options to derive Serialize
along with existing traits.
Files | Change Summary |
---|---|
src/mito2/src/compaction/compactor.rs |
Added use serde::{Deserialize, Serialize}; and updated MergeOutput struct to derive Serialize . |
src/mito2/src/region/options.rs |
Applied Serialize to RegionOptions , CompactionOptions , TwcsOptions , IndexOptions , |
InvertedIndexOptions , MemtableOptions , and PartitionTreeOptions structs/enums. |
In the code, a change so bright,
Serialization takes its flight.
Withserde
's might, the data flows,
Inmito2
, new life it shows.
JSON dreams and seamless streams,
In Rust we trust, fulfilling schemes. 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
MakePickerOutput
andMergeOutput
serializable and deserializable. It's easy to transmit over the network in JSON format.In order to use#[serde(skip)]
, the PR will makefile_purger
inFileHandleInner
as Option type.MergeOutput
serializable and deserializable;RegionOptions
serializable, and we can marshal it into JSON string;Checklist
Summary by CodeRabbit
New Features
RegionOptions
,CompactionOptions
,TwcsOptions
,IndexOptions
,InvertedIndexOptions
,MemtableOptions
, andPartitionTreeOptions
.Improvements
MergeOutput
struct with serialization and deserialization capabilities for better data management and interchange.