search

GreptimeTeam / greptimedb

An open-source, cloud-native, unified time series database for metrics, logs and events with SQL/PromQL supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
4.23k stars 303 forks source link

test: add e2e test for region failover #4188

Closed WenyXu closed 3 months ago

WenyXu commented 3 months ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

4161

wait for #4172

What's changed and what's your intention?

sequenceDiagram
    participant Client
    participant Cluster
    participant Datanode
    participant K8s

    Client->>Cluster: Initialize connections
    Cluster->>Datanode: Fetch node info
    Datanode-->>Cluster: Return node info
    Cluster->>Client: Return connections
    Client->>K8s: Simulate pod failure
    Cluster-->>Datanode: Region failover
    Client->>K8s: Recover pod
    Client->>Cluster: Validate data consistency
    Cluster-->>Client: Data validation result

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

[!WARNING]

Rate limit exceeded

@WenyXu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 45 minutes and 11 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between e167bbeba667be5facd60af4806f5982bb83bfbc and ed3c0188c759ada4f16e14ca25f2b220da34b9c6.

Walkthrough

The recent updates enhance the tests-fuzz/src/utils.rs by adding new modules (cluster_info, partition, pod_failure, and wait) and refactoring existing functionalities to improve cluster management, logging, and failover fuzz testing. These updates primarily introduce new functions and structs to manage cluster nodes, handle partition data, simulate and recover from pod failures, and wait for specified conditions. They also refine MySQL connection handling for better logging control.

Changes

Files/Modules Change Summary
tests-fuzz/src/utils.rs Added new modules for cluster info, partitions, pod failures, and wait actions. Refactored MySQL connections.
.../utils/cluster_info.rs Introduced node info fetching, wait-for-datanode readiness functions, and NodeInfo struct.
.../utils/partition.rs Added structs and functions for partition management, including counting, fetching data, and handling region distribution.
.../utils/pod_failure.rs Provided functions to simulate and recover from pod failures in Kubernetes.
.../utils/wait.rs Added function for condition-based waiting within a specified timeout period.
.../targets/failover/fuzz_failover_mito_regions.rs Introduced a new fuzzing target that tests failover scenarios, including schema generation, data insertion, pod failure simulation, and data consistency validation.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Cluster
    participant Datanode
    participant K8sPod
    participant Database

    Client->>Cluster: Initialize connections
    Cluster->>Datanode: Fetch node info
    Datanode-->>Cluster: Return node info
    Cluster->>Client: Return connections
    Client->>K8sPod: Simulate pod failure
    K8sPod-->Database: Data operations interrupted
    Client->>K8sPod: Recover pod
    K8sPod-->Database: Resume data operations
    Client->>Cluster: Validate data consistency
    Cluster-->>Client: Data validation result

Poem

In clusters wide and nodes so bright,
We fetch, we wait, from day to night.
With partitions spread and pods aflame,
We test and tweak, enhancing fame.
Connections strong, failover's dance,
Our code refined, it leads the chance.
🌟👩‍💻✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 2.47525% with 197 lines in your changes missing coverage. Please review.

Project coverage is 84.53%. Comparing base (8cbe716) to head (ed3c018). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4188 +/- ## ========================================== - Coverage 84.89% 84.53% -0.36% ========================================== Files 1039 1044 +5 Lines 182758 183697 +939 ========================================== + Hits 155150 155294 +144 - Misses 27608 28403 +795 ```
WenyXu commented 3 months ago

@coderabbitai resolve

coderabbitai[bot] commented 3 months ago
Actions performed Comments resolved.
WenyXu commented 3 months ago

@coderabbitai resolve

coderabbitai[bot] commented 3 months ago
Actions performed Comments resolved.