search

GreptimeTeam / greptimedb

An open-source, cloud-native, distributed time-series database with PromQL/SQL/Python supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
3.97k stars 281 forks source link

fix: `region_peers` returns same region_id for multi logical tables #4190

Closed realtaobo closed 1 week ago

realtaobo commented 2 weeks ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Resolve #4157

What's changed and what's your intention?

as title.

image

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The changes optimize how region and peer information is collected and stored in the information_schema.region_peers table of the INFORMATION_SCHEMA database. Key modifications include adjustments to the add_region_peers method to accept a table_id parameter and the introduction of new SQL test files illustrating the creation, querying, and dropping of region peer-related tables.

Changes

File/Directory Path Change Summary
src/catalog/src/information_schema/region_peers.rs Modified the add_region_peers method to accept a table_id parameter and adjusted its logic for handling region and peer information.
.../distributed/information_schema/region_peers.result Introduced the creation of multiple tables related to region peers and included a sample SELECT query on the region_peers table and subsequent table drops.
.../standalone/information_schema/region_peers.result Included the creation of several region peer-related tables, data selection, and table drops before switching back to the public schema.
.../distributed/information_schema/region_peers.sql Added definitions for multiple tables in the INFORMATION_SCHEMA database related to region peers, partitioning logic, and a SELECT query on region peers.
.../standalone/information_schema/region_peers.sql Defined the structure of region peer-related tables and included partitioning, data selection logic, and table drops in the INFORMATION_SCHEMA database.
.../standalone/common/information_schema/region_peers.result Added logic for creating/manipulating tables in the information_schema database and a query for counting distinct region_id values, followed by table drops.
.../standalone/common/information_schema/region_peers.sql Introduced table definitions related to region peers in the INFORMATION_SCHEMA database, including a count query and table dropping logic.

Assessment against linked issues

Objective Addressed Explanation
information_schema.region_peers returns same region_id multiple times (#4157) ✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.85%. Comparing base (07cbaba) to head (c4f26cc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4190 +/- ## ========================================== - Coverage 85.11% 84.85% -0.27% ========================================== Files 1028 1028 Lines 180903 180908 +5 ========================================== - Hits 153970 153503 -467 - Misses 26933 27405 +472 ```
fengjiachun commented 1 week ago

PTAL @WenyXu

WenyXu commented 1 week ago

@realtaobo, that is nicely done. Would you like to add a sqlness test for this case?

WenyXu commented 1 week ago

Thanks!