GreptimeTeam / greptimedb

An open-source, cloud-native, distributed time-series database with PromQL/SQL/Python supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
3.97k stars 281 forks source link

feat(puffin): support lz4 compression for footer #4194

Closed zhongzc closed 1 week ago

zhongzc commented 1 week ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

4193

What's changed and what's your intention?

add lz4_flex as the dependency to get things done.

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

These changes introduce support for LZ4 compression/decompression into the puffin codebase. Specifically, they expand the Error enum to include LZ4-related errors, modify the file reader and writer to handle LZ4-compressed footers, and update unit tests to ensure the functionality works correctly. The new methods and fields ensure that users can opt for LZ4 compression for file footers, potentially improving both performance and storage efficiency.

Changes

File Summary
src/puffin/Cargo.toml Added the lz4_flex dependency version "0.11".
src/puffin/src/error.rs Added new error variants for Lz4Compression and Lz4Decompression to the Error enum.
.../file_format/reader/footer.rs Added support for LZ4 decompression in parse_payload, incorporating necessary imports and error handling.
src/puffin/src/file_format/writer.rs Introduced set_footer_lz4_compressed method to PuffinSyncWriter and PuffinAsyncWriter traits for setting LZ4 compression.
.../writer/file.rs Added footer_lz4_compressed field and set_footer_lz4_compressed method to PuffinFileWriter struct.
.../writer/footer.rs Added lz4_compressed field and modified methods for conditional LZ4 compression in FooterWriter struct.
src/puffin/src/tests.rs Modified test functions to accept footer_compressed parameter, testing both true and false cases for LZ4 compression.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PuffinWriter
    participant LZ4

    User ->> PuffinWriter: set_footer_lz4_compressed(true)
    activate PuffinWriter
    PuffinWriter ->> LZ4: Compress footer payload
    deactivate PuffinWriter

    User ->> PuffinWriter: Write data
    PuffinWriter ->> LZ4: Optionally compress data
    PuffinWriter ->> User: Data written with footers optionally compressed

Poem

In lines of Rust we write, compress, With LZ4, our files caress. Footers now, in this quest, Stored compact, they stand the test. Errors new, tests revised, In puffin's code, we realize. CodeRabbit's joy, in bytes we trust, In LZ4, our data's just.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.81%. Comparing base (5566dd7) to head (8f6d47f). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4194 +/- ## ========================================== - Coverage 85.06% 84.81% -0.25% ========================================== Files 1028 1028 Lines 180477 180903 +426 ========================================== - Hits 153514 153429 -85 - Misses 26963 27474 +511 ```