coderabbitai[bot]
commented
1 week ago [!WARNING]
Rate limit exceeded
@killme2008 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 46 minutes and 59 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between f58ed88b72b6a71342d765a7ace2ce09afaed536 and 4cbb4c85f54aeeb4f61dcc226e3504da01bdb3d1.
Walkthrough
The changes introduce a function resolve_addr to handle hostname and port resolution for network addresses. This affects the HeartbeatTask struct in datanode and frontend by using peer_addr instead of server_addr. Configuration files are updated to clarify the usage of hostnames for the gRPC server, enhancing documentation and code reliability. Code cleanliness is improved by removing redundant functions and test cases.
Changes
| File Path | Change Summary |
|---|---|
| src/datanode/src/heartbeat.rs | Renamed server_addr to peer_addr, used resolve_addr for address resolution, and removed redundant resolve_addr function along with its test cases. |
| src/frontend/src/heartbeat.rs | Similar updates to heartbeat.rs as in datanode, with peer_addr and resolve_addr usages. |
| src/servers/src/addrs.rs | Introduced resolve_addr function and added tests for address resolution logic. |
| src/servers/src/lib.rs | Added the new addrs module to the public scope for use in the project. |
| config/datanode.example.toml | Updated comments to clarify the hostname field’s purpose for the gRPC server in the configuration file. |
| config/frontend.example.toml | Added a new hostname field in the [grpc] section for specifying external host connections and advertisement to metasrv. |
| config/config.md | Clarified the grpc.hostname configuration parameter with additional notes on its purpose and usage. |
Sequence Diagram(s)
sequenceDiagram
participant Client
participant Datanode
participant Frontend
participant Servers as Servers::Addrs
Client->>+Datanode: Sends request with server name
Datanode->>+Servers: Resolve address using `resolve_addr`
Servers-->>-Datanode: Returns `peer_addr`
Datanode->>Frontend: Communicates with `peer_addr`
Frontend->>Frontend: Uses resolved address
Frontend-->>Client: Response with resolved peer informationPoem
In code’s vast land, a task arose,
With addresses both near and far, they chose.
From server to peer, the change was born,
To resolve with grace each early morn.
Now networks link with clearer sight,
A seamless dance from day to night.
🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
killme2008
fengjiachun
sunng87
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
4186
What's changed and what's your intention?
Fixed the wrong peer address that frontend registers.
Checklist
Summary by CodeRabbit
New Features
grpc.hostnameto improve clarity and understanding of its usage for external connections.Improvements
hostnamefield for gRPC servers, enhancing documentation for end-users.Refactor
server_addrtopeer_addrin heartbeat components for consistency.