Closed etolbakov closed 3 months ago
The updates enhance interval handling in SQL statements by refining the regex pattern to match more types of interval formats, including plus/minus signs and ASCII characters. Additionally, new tests verify the correct transformation and representation of compound intervals, including negative hour and minute values in SQL queries.
File(s) | Change Summary |
---|---|
src/sql/src/statements/transform/expand_interval.rs |
Updated regex pattern to match plus/minus signs and ASCII characters; added tests for compound intervals. |
tests/cases/standalone/common/types/interval/interval.result |
Added SQL queries showcasing the representation of negative hour and minute intervals in the result set. |
tests/cases/standalone/common/types/interval/interval.sql |
Introduced new interval selections, including negative hour and minute intervals, in SQL queries. |
In code we weave where patterns form, Matching signs and strings, through the storm. Intervals now, both bright and gray, With hours and minutes in a succinct array. Test cases rise with compound cheer, In SQL's language, transformations appear! 🌐
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.76%. Comparing base (
cdd4baf
) to head (839d944
).
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
https://github.com/GreptimeTeam/greptimedb/issues/4168 https://github.com/GreptimeTeam/greptimedb/pull/4182
What's changed and what's your intention?
Fix compound signed number case handling
Checklist
Summary by CodeRabbit
New Features
Tests