search

GreptimeTeam / greptimedb

An open-source, cloud-native, distributed time-series database with PromQL/SQL/Python supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
3.96k stars 282 forks source link

feat: FlownodeClient #4206

Closed discord9 closed 1 week ago

discord9 commented 1 week ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

added FlownodeClient which can send requests to Flownode in distributed mode

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes introduce significant updates to the Rust client and meta-server modules. The Client structure gets a new method for initializing PbFlowClient, multiple components are renamed from DatanodeClients to NodeClients, and a new FlowRequester struct is added for handling flow requests. Error handling is improved with a new FlowServer variant, facilitating better management of flownode operations.

Changes

Files Change Summaries
src/client/src/client.rs Added a new raw_flow_client method to the Client implementation, initializing and returning a PbFlowClient.
src/client/src/client_manager.rs Renamed DatanodeClients to NodeClients, updated method implementations and references, and introduced a FlowRequester dependency for handling flownode requests.
src/client/src/error.rs Added a new FlowServer variant to the Error enum, updated ErrorExt implementation to handle this new variant alongside others.
src/client/src/flow.rs Introduced FlowRequester struct with methods for handling and inserting flow requests, implementing the Flownode trait for asynchronous operations.
src/client/src/lib.rs Added a new module flow.
src/cmd/src/frontend.rs, Renamed DatanodeClients to NodeClients, updated instantiation logic accordingly.
src/meta-srv/src/.../builder.rs, Updated import and instantiation logic to replace DatanodeClients with NodeClients.
src/meta-srv/src/mocks.rs, Renamed DatanodeClients to NodeClients, updated function signatures accordingly.
src/meta-srv/src/procedure/tests.rs, Renamed DatanodeClients to NodeClients in import statements and function calls.
tests-integration/src/cluster.rs Updated references from DatanodeClients to NodeClients in the client::client_manager module.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FlowRequester
    participant Client
    participant PbFlowClient

    User->>FlowRequester: Make flow request
    FlowRequester->>Client: Initialize `PbFlowClient`
    Client->>PbFlowClient: Init with configurations
    Client-->>FlowRequester: Return `PbFlowClient`
    FlowRequester->>PbFlowClient: Handle flow request
    PbFlowClient-->>FlowRequester: Flow response
    FlowRequester-->>User: Return Flow response

Poem

In fields of code, where errors abound,
The NodeClients now elegantly surround.
With FlowRequester handling requests with care,
Our flows traverse, beyond compare.
Errors meet new variances, to guide the way,
In our rustling cluster, harmony will stay.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 5.00000% with 76 lines in your changes missing coverage. Please review.

Project coverage is 84.77%. Comparing base (cdd4baf) to head (ca774e8). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4206 +/- ## ========================================== - Coverage 85.05% 84.77% -0.28% ========================================== Files 1031 1032 +1 Lines 181276 181899 +623 ========================================== + Hits 154176 154200 +24 - Misses 27100 27699 +599 ```
sunng87 commented 1 week ago

Do we really want to rename DatanodeClient to NodeClient? Datanode is a term in our database while Node sounds like more general purpose

I see it also used for flow nodes, that's ok