feat: validate partition rule on create table

waynexia commented 1 week ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Validate partition rule on CREATE TABLE

Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

New Features
- Improved error handling with a new InvalidPartition error variant, providing more specific error messages for invalid partition rules.
Bug Fixes
- Enhanced validation for partition rules, ensuring errors are correctly flagged when rules are improperly defined.
Refactor
- Streamlined method signatures for partition rule checking, simplifying the code and improving maintainability.
Tests
- Added tests to check for appropriate error handling when creating tables with invalid partition rules.

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes across the files focus on enhancing error handling and partitioning logic within the system. Key modifications include adding a new InvalidPartition error variant, improving the MultiDimPartitionRule implementation, and expanding test cases to cover invalid partition rules. These updates aim to make the system more robust and informative when dealing with partition-related errors.

Changes

Files	Change Summary
`src/operator/src/error.rs`	Added `InvalidPartition` variant with associated fields and updated `ErrorExt` for handling it.
`src/operator/src/statement/ddl.rs`	Renamed `InvalidPartitionRuleSnafu` to `InvalidPartitionSnafu` and added `MultiDimPartitionRule`.
`src/partition/src/multi_dim.rs`	Refactored `check` method in `RuleChecker` struct to use instance variables directly.
`tests/cases/standalone/common/partition.sql`	Introduced invalid partition rule resulting in error for incorrect partition conditions.
`tests/cases/standalone/common/partition.result`	Reflected changes in error output for invalid partition rule with specific error messages.

Sequence Diagram(s)

(Omitted; the changes don't significantly alter control flow functionality.)

Poem

Partitions tall, partitions wide,
New rules and checks now on our side,
Errors caught with greater might,
Ensuring data stays just right.
A journey through our every query,
Ends in results accurate, not dreary.
🌟📝

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.61%. Comparing base (0fc18b6) to head (e17b36c). Report is 40 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4213 +/- ## ========================================== - Coverage 84.92% 84.61% -0.31% ========================================== Files 1023 1039 +16 Lines 179298 182766 +3468 ========================================== + Hits 152272 154653 +2381 - Misses 27026 28113 +1087 ```

GreptimeTeam / greptimedb