GreptimeTeam / greptimedb

An open-source, cloud-native, distributed time-series database with PromQL/SQL/Python supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
3.96k stars 282 forks source link

ci: add the github actions of pushing image to aws public ecr #4214

Open daviderli614 opened 1 week ago

daviderli614 commented 1 week ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Same as this: https://github.com/GreptimeTeam/greptimedb-operator/pull/155

What's changed and what's your intention?

Add push image to aws container image registry.

Need to add two repositoriy variables: aws-image-registry: public.ecr.aws/i8k6a5e1 AWS_ECR_REGION: us-east-1

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

The recent changes across various GitHub Actions and workflows centralize around integrating AWS ECR for storing Docker images. New parameters and steps were added to authenticate with AWS, log in to Amazon ECR, and push the Docker images to both DockerHub and ECR. These modifications ensure that Docker images for different platforms are built and stored systematically in Amazon ECR and DockerHub repositories.

Changes

File(s) Change Summary
.../actions/build-dev-builder-images/action.yml Added AWS credentials and image registry parameters; included steps to configure AWS credentials and push images to ECR and DockerHub.
.../actions/build-greptime-images/action.yml Introduced AWS-related inputs for access key, secret key, region, and registry; updated steps for AWS configuration and ECR login.
.../actions/build-images/action.yml New AWS parameters for credentials and ECR setup; added steps to build and push images to ECR.
.../actions/build-linux-artifacts/action.yml Replaced hardcoded values for IMAGE_NAMESPACE and IMAGE_REGISTRY with variables for dynamic configuration.
.../workflows/dev-build.yml Added release-images-to-ecr job for building and pushing images to ECR; updated dependencies and notification logic.
.../workflows/nightly-build.yml Introduced release-images-to-ecr step before release-cn-artifacts; modified notifications to handle the ECR step.
.../workflows/release-dev-builder-images.yaml Added AWS-related variables for credentials and registry information.
.../workflows/release.yml New job release-images-to-ecr created to build and push images to ECR; adjusted dependencies and notification conditions.

Sequence Diagram(s)

sequenceDiagram
    actor Developer
    participant GitHub Actions
    participant AWS ECR
    participant DockerHub

    Developer->>GitHub Actions: Push code to repository
    GitHub Actions->>GitHub Actions: Trigger workflow
    GitHub Actions->>AWS ECR: Configure AWS credentials
    GitHub Actions->>AWS ECR: Log in to Amazon ECR
    GitHub Actions->>GitHub Actions: Build Docker images
    GitHub Actions->>AWS ECR: Push images to Amazon ECR
    GitHub Actions->>DockerHub: Push images to DockerHub
    GitHub Actions->>GitHub Actions: Notify build results

Poem

In the realm where code does thrive,
AWS ECR keeps our images alive.
With credentials primed and regions set,
Our Docker dreams are firmly met.
To DockerHub and ECR they sail,
Ensuring builds never fail.
🌟🚀🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.57%. Comparing base (8cbe716) to head (e741a1f). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4214 +/- ## ========================================== - Coverage 84.89% 84.57% -0.33% ========================================== Files 1039 1040 +1 Lines 182758 183023 +265 ========================================== - Hits 155150 154783 -367 - Misses 27608 28240 +632 ```
zyy17 commented 1 week ago

Suggestion: The original image can be built once and copied anywhere, it will make the CI code simple and easy to read.