Open daviderli614 opened 1 week ago
The recent changes across various GitHub Actions and workflows centralize around integrating AWS ECR for storing Docker images. New parameters and steps were added to authenticate with AWS, log in to Amazon ECR, and push the Docker images to both DockerHub and ECR. These modifications ensure that Docker images for different platforms are built and stored systematically in Amazon ECR and DockerHub repositories.
File(s) | Change Summary |
---|---|
.../actions/build-dev-builder-images/action.yml | Added AWS credentials and image registry parameters; included steps to configure AWS credentials and push images to ECR and DockerHub. |
.../actions/build-greptime-images/action.yml | Introduced AWS-related inputs for access key, secret key, region, and registry; updated steps for AWS configuration and ECR login. |
.../actions/build-images/action.yml | New AWS parameters for credentials and ECR setup; added steps to build and push images to ECR. |
.../actions/build-linux-artifacts/action.yml | Replaced hardcoded values for IMAGE_NAMESPACE and IMAGE_REGISTRY with variables for dynamic configuration. |
.../workflows/dev-build.yml | Added release-images-to-ecr job for building and pushing images to ECR; updated dependencies and notification logic. |
.../workflows/nightly-build.yml | Introduced release-images-to-ecr step before release-cn-artifacts ; modified notifications to handle the ECR step. |
.../workflows/release-dev-builder-images.yaml | Added AWS-related variables for credentials and registry information. |
.../workflows/release.yml | New job release-images-to-ecr created to build and push images to ECR; adjusted dependencies and notification conditions. |
sequenceDiagram
actor Developer
participant GitHub Actions
participant AWS ECR
participant DockerHub
Developer->>GitHub Actions: Push code to repository
GitHub Actions->>GitHub Actions: Trigger workflow
GitHub Actions->>AWS ECR: Configure AWS credentials
GitHub Actions->>AWS ECR: Log in to Amazon ECR
GitHub Actions->>GitHub Actions: Build Docker images
GitHub Actions->>AWS ECR: Push images to Amazon ECR
GitHub Actions->>DockerHub: Push images to DockerHub
GitHub Actions->>GitHub Actions: Notify build results
In the realm where code does thrive,
AWS ECR keeps our images alive.
With credentials primed and regions set,
Our Docker dreams are firmly met.
To DockerHub and ECR they sail,
Ensuring builds never fail.
🌟🚀🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.57%. Comparing base (
8cbe716
) to head (e741a1f
). Report is 3 commits behind head on main.
Suggestion: The original image can be built once and copied anywhere, it will make the CI code simple and easy to read.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Same as this: https://github.com/GreptimeTeam/greptimedb-operator/pull/155
What's changed and what's your intention?
Add push image to aws container image registry.
Need to add two repositoriy variables:
aws-image-registry
:public.ecr.aws/i8k6a5e1
AWS_ECR_REGION
:us-east-1
Checklist
Summary by CodeRabbit
New Features
release-images-to-ecr
for building and pushing images to AWS ECR.Chores
Documentation