Closed fengjiachun closed 1 week ago
The recent updates enhance the HTTP server configuration options, allowing more flexibility by enabling the timeout and body limit settings to be disabled by setting their values to 0. This change affects configuration files and the HTTP server's implementation, providing improved configurability and control.
Files | Change Summary |
---|---|
config/config.md | Updated http.timeout and http.body_limit to allow disabling by setting to 0. |
config/frontend.example.toml | Modified timeout and body_limit settings to reflect disabling by setting to 0. |
config/standalone.example.toml | Adjusted timeout and body_limit settings to allow disabling by setting to 0. |
src/servers/src/http.rs | Enhanced build method in HttpServer to conditionally create timeout_layer and body_limit_layer based on server options. |
Amidst configs and code's endless flight,
We grant more freedom to HTTP's might.
Disable the limits, let requests run free,
In zero we trust, simplicity we see.
Our code now blossoms, our servers stand tall,
For now, constraints shall no longer enthrall.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 69.23077%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 84.56%. Comparing base (
948c869
) to head (863e591
).
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Set timeout or body limit to 0 to disable them.
Checklist
Summary by CodeRabbit
http.timeout
to 0.http.body_limit
to 0.