WenyXu commented 1 week ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

4161

What's changed and what's your intention?

Register failure detector during create table procedure. The datanode may crash without sending a heartbeat that contains information about newly created regions, which may prevent the RegionSupervisor from detecting failures in these newly created regions.
Register failure detector during rollback region migration procedure. The original failure detector was removed once the procedure was triggered. Therefore, we need to register the failure detector for the failed region during rollback.
Deregister failure detectors during drop table procedure. Once the regions were dropped, subsequent heartbeats no longer include these regions. Therefore, we need to remove the failure detectors for these dropped regions.

Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

New Features
- Introduced region failure detection for enhanced table creation and region management processes.
Improvements
- Updated handling of region failure detectors across various components.
- Added initialization and registration of failure detectors in multiple workflows.
Configuration
- Adjusted acceptable_heartbeat_pause value from "3000ms" to "10000ms" for better failure detection timing.
Tests
- Updated test setups to include failure detector initialization and validated event handling.
- Modified random generation parameters in failover tests for optimized data handling.

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes introduce a RegionFailureDetectorController to manage region failure detection across various parts of the system. Modifications include adding and initializing the controller, updating procedures to use the controller, and adjusting configurations and tests to incorporate the new failure detection mechanism.

Changes

Files	Change Summaries
`.../standalone.rs`, `.../ddl.rs`, `.../ddl/create_table.rs`	Added `NoopRegionFailureDetectorControl` and updates to initialization, import adjustments, and inclusion in various procedures related to region failure detection.
`.../drop_database.rs`, `.../drop_table.rs`	Added `ClusterId` entity in several structs, modified procedure implementations to utilize `ClusterId`, and updated drop actions to include failure detector handling.
`.../executor.rs`, `.../cursor.rs`, `.../metadata.rs`	Added `cluster_id` to context structs and procedure handling, modified method signatures and initialization to include this new field.
`.../failure_handler.rs`, `.../failure_detector.rs`,	Added `heartbeat_acceptor` parameter to method signatures, updated methods to handle new failure detection logic, refactored detection methods with `DetectingRegion`.
`config/metasrv.example.toml`, `config/config.md`	Updated `acceptable_heartbeat_pause` value to `10000ms`.
`tests-fuzz/.../fuzz_failover_mito_regions.rs`	Modified random generation parameters for `rows`, `inserts`, and `parallelism` in the fuzzing test to reduce the range and increase test efficiency.
`.../rollback_downgraded_region.rs`, `.../supervisor.rs`	Introduced `RegionFailureDetectorControl` for managing failure detectors, added event handling for registering/deregistering detectors, and enhanced related test cases.

In meadows wide, regions bloom anew,

With failure detectors, robust and true.

Procedures align, clusters refined,

Heartbeats steady, no regions left behind.

Code sings in brevity, a harmonious cue,

As systems evolve, their strengths accrue.

[!TIP]

Early access features: disabled
We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

WenyXu commented 1 week ago

@coderabbitai resolve

coderabbitai[bot] commented 1 week ago

Actions performed

Comments resolved.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 83.94649% with 48 lines in your changes missing coverage. Please review.

Project coverage is 84.59%. Comparing base (a7aa556) to head (cef5b65). Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4223 +/- ## ========================================== - Coverage 84.86% 84.59% -0.28% ========================================== Files 1045 1046 +1 Lines 184265 184597 +332 ========================================== - Hits 156384 156158 -226 - Misses 27881 28439 +558 ```

WenyXu commented 6 days ago

@fengjiachun PTAL

fengjiachun commented 6 days ago

@coderabbitai Hi

coderabbitai[bot] commented 6 days ago

[!TIP] For best results, initiate chat on the files or code changes.

@fengjiachun Hi! How can I assist you today?

WenyXu commented 4 days ago

Another suggestion: can we add some tests to cover these cases?

Yes, tests will be introduced in following PRs