refactor: add interceptor after Influxdb lines are converted to grpc row insert

MichaelScofield commented 1 week ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

... so that other projects could modify the row insert according to their specific intention.

Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

Refactor
- Improved the initialization sequence for frontend services, simplifying the method calls and argument passing for better performance and maintainability.

These changes enhance the backend structure without affecting user-facing features directly.

coderabbitai[bot] commented 1 week ago

[!WARNING]

Rate limit exceeded

@tisonkun has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 42 seconds before requesting another review.

How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.

Commits
Files that changed from the base of the PR and between a9bf8cafc550e1a4d12fa2eec6f100da1473bf7c and d5cb7ba48c90aea4f75b2520db74fe1af20e23c5.

Walkthrough

The recent changes streamline the StartCommand implementation in both frontend.rs and standalone.rs by reordering and modifying arguments in crucial methods. The FrontendBuilder::new() method now receives an opts.clone() argument first, while the Services::new() method no longer clones the opts argument. Additionally, invoking the build_servers() method no longer requires the opts argument, simplifying the method calls.

Changes

Files	Change Summary
`src/cmd/src/frontend.rs`	`FrontendBuilder::new()` restructured to put `opts.clone()` first; `opts.clone()` removed from `Services::new()`.
`src/cmd/src/standalone.rs`	`FrontendBuilder::new()` restructured to include `fe_opts.clone()` first; `fe_opts.clone()` removed from `Services::new()`.
`tests-integration/src/standalone.rs`	Added `opts.frontend_options()` in `FrontendBuilder::new()`.

Poem

In the land where code does grow,
Frontend builders start the show.
With opts up front, they lead the way,
Simpler servers come to play.
Services shed their cloning woes,
Through streamlined paths, the data flows.

[!TIP]

Early access features: enabled
We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.82%. Comparing base (2665616) to head (d5cb7ba).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4225 +/- ## ========================================== - Coverage 84.83% 84.82% -0.01% ========================================== Files 1049 1049 Lines 186312 186328 +16 ========================================== - Hits 158052 158051 -1 - Misses 28260 28277 +17 ```

killme2008 commented 6 days ago

@MichaelScofield It's better to use an option to control this behavior and it's disabled by default.

MichaelScofield commented 6 days ago

@killme2008 The current behavior is unaffected, new influxdb tables are still nanosecond time index. This PR simply brings compatibility back, so I don't think there's a need for an option.

killme2008 commented 6 days ago

@killme2008 The current behavior is unaffected, new influxdb tables are still nanosecond time index. This PR simply brings compatibility back, so I don't think there's a need for an option.

Alignment and checking typically impact performance, often unnecessary.

In other words, the user may create a table with a millisecond time index, and ingestion with influxdb, which we want to prohibit.

killme2008 commented 6 days ago

@MichaelScofield We already discussed this before and have an agreement. Maybe you can discuss it directly with @fengjiachun . I have to sleep.

MichaelScofield commented 6 days ago

@killme2008 I have added an option for that.

GreptimeTeam / greptimedb