feat: output multiple partition in MergeScanExec

waynexia commented 6 days ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Use target_partitions to guide the parallelism of MergeScanExec

(This was intended)

Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

New Features
- Enhanced query execution with new partitioning logic, reducing redundant partition steps.
Bug Fixes
- Fixed issues with query result sorting by introducing SortPreservingMergeExec.
Performance Improvements
- Improved performance by removing unnecessary RepartitionExec steps in query plans.
Testing
- Updated test results to reflect changes in the physical execution plans and query results.

coderabbitai[bot] commented 6 days ago

Walkthrough

Several modifications were made to the query planning and execution logic, focusing on enhanced partition handling, sorting improvements, and optimization of execution plans by removing unnecessary repartitioning nodes. These changes refine data processing flows, such as introducing target_partition in MergeScanExec, altering sorting mechanisms, and updating query plans in various test cases.

Changes

File(s) or Group	Summary
`merge_scan.rs`, `planner.rs`	Introduced `target_partition` to `MergeScanExec`, updating methods like `to_stream` and `execute` to utilize partition info.
`range_manipulate.rs`	Updated `properties` initialization in `RangeManipulateExec` to derive from input properties.
Various test files (`.result` and `.sql`)	Made various updates including removal of `RepartitionExec` nodes, adding `SortPreservingMergeExec`, and adjusting sorting parameters.

Sequence Diagram(s)

sequenceDiagram
    participant QueryPlanner
    participant MergeScanExec
    participant DistExtensionPlanner
    actor User

    User->>QueryPlanner: Submit Query
    QueryPlanner->>DistExtensionPlanner: Plan Execution
    DistExtensionPlanner->>DistExtensionPlanner: Fetch Config
    DistExtensionPlanner->>QueryPlanner: Return Plan with target_partition
    QueryPlanner->>MergeScanExec: Distribute to target_partition
    MergeScanExec->>MergeScanExec: Execute with target_partition
    MergeScanExec->>User: Return Query Result

Poem

In the land of code where data flows, Partitions dance and merge like prose. Sorting now with grace, so fine, Preservation's touch in every line. No more nodes that don't belong, Efficiency sings a joyful song!

✨🐇🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.58%. Comparing base (352cc9d) to head (f80490d). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4227 +/- ## ========================================== - Coverage 84.81% 84.58% -0.24% ========================================== Files 1044 1045 +1 Lines 183697 184265 +568 ========================================== + Hits 155809 155852 +43 - Misses 27888 28413 +525 ```

GreptimeTeam / greptimedb