fix!: forbid to change information_schema

CookiePieWw commented 4 days ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3653

What's changed and what's your intention?

As title. Following ops in information_schema are forbidden in this patch:

create, drop and truncate tables
drop database
insert into/delete from tables

Updated some sqlness tests for it.

Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

New Features
- Added checks to prevent modifications to read-only schemas and tables, specifically targeting the information_schema.
Bug Fixes
- Improved error handling to provide specific errors when attempting to modify read-only schemas and tables.
Refactor
- Enhanced schema and table operation checks to ensure compliance with read-only constraints.

coderabbitai[bot] commented 4 days ago

Walkthrough

The recent changes introduce checks to ensure that operations on read-only schemas and tables, specifically within the "information_schema," result in user-friendly error messages rather than internal errors. These checks have been added across several modules, enhancing user experience by preventing unwanted modifications and providing descriptive error messages.

Changes

File Path	Change Summary
`src/common/catalog/src/consts.rs`	Added `is_readonly_schema` function to check if a schema is read-only.
`src/operator/src/req_convert/insert/stmt_to_region.rs`	Added a check to prevent operations on "information_schema" and include `SchemaReadOnlySnafu` error.
`src/operator/src/statement/ddl.rs`	Integrated checks to disallow operations on "information_schema" in multiple `StatementExecutor` functions, adding `SchemaReadOnlySnafu` errors.
`src/query/src/datafusion.rs`	Implemented checks for read-only tables in the `DatafusionQueryEngine`, introducing `TableReadOnlySnafu` errors.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Application
    participant QueryEngine
    participant Catalog
    participant SchemaRegistry

    User->>Application: Perform operation on information_schema
    Application->>QueryEngine: Forward request
    QueryEngine->>Catalog: Check if schema/table is read-only
    Catalog-->>QueryEngine: Schema/table is read-only
    QueryEngine-->>Application: Return SchemaReadOnlySnafu / TableReadOnlySnafu error
    Application-->>User: Display user-friendly error message

Assessment against linked issues

Objective	Addressed	Explanation
Improve error message for read-only tables (3653)	✅

Poem

In the code where data flows,
A rabbit hopped and gently shows,
Errors now more friendly made,
No more fears of updates staid.
Schema checks in place now be,
Just for you, from me, Code Bunny.🐰

[!TIP]

Early access features: enabled
We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.70%. Comparing base (a7aa556) to head (3f545b7). Report is 19 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4233 +/- ## ========================================== - Coverage 84.86% 84.70% -0.17% ========================================== Files 1045 1054 +9 Lines 184265 187005 +2740 ========================================== + Hits 156384 158396 +2012 - Misses 27881 28609 +728 ```

CookiePieWw commented 3 days ago

Updated with a read-only check function, error code and some sqlness tests. PTAL @killme2008

I forgot to sync the clock before commit, so it may be a little strange that f336170bcdada6c332fddd3be2108728a9d473a6 is ahead of the comments QaQ.

GreptimeTeam / greptimedb