feat: forgot collect flownode clusterinfo handler

fengjiachun commented 4 days ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Forgot to add CollectFlownodeClusterInfoHandler into the pipeline, which will result in the inability to collect the cluster info of flownodes (this part of information for flownodes has not been enabled yet).
Two handlers had unclear names, causing misunderstandings. They have now been given more appropriate names: CollectStatsHandler to ExtractStatHandler PersistStatsHandler to CollectStatsHandler

Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

New Features
- Introduced a new statistics extraction handler for improved data processing and role validation.
- Enhanced cache management and data persistence in the statistics collection handler.
Bug Fixes
- Improved handling of stale heartbeats to ensure accurate data collection.
Refactor
- Replaced and renamed handlers for clarity and better functionality in the codebase.

coderabbitai[bot] commented 4 days ago

Walkthrough

The meta-handler updates introduced ExtractStatHandler and refined CollectStatsHandler while removing PersistStatsHandler. These changes enhanced data persistence, heartbeat processing, and cache management for statistics, aiming to improve stability and efficiency in the meta-service.

Changes

File(s)	Change Summary
`src/meta-srv/src/handler.rs`	Added `extract_stat_handler` module; removed `persist_stats_handler` module; swapped handlers in test modules accordingly.
`src/meta-srv/src/handler/collect_stats_handler.rs`	Enhanced `CollectStatsHandler` with `PutRequest`, `DashMap`, and new `EpochStats` struct; improved heartbeat and cache management.
`src/meta-srv/src/handler/extract_stat_handler.rs`	Implemented `ExtractStatHandler` with `HeartbeatHandler` trait for validating roles and accumulating statistics from requests.
`src/meta-srv/src/metasrv/builder.rs`	Updated handler declarations in `MetasrvBuilder`: renamed and added new handlers such as `ExtractStatHandler` and `CollectFlownodeClusterInfoHandler`.

Sequence Diagrams

Below is a sequence diagram demonstrating the updated heartbeat handling flow with the new CollectStatsHandler and ExtractStatHandler.

sequenceDiagram
    participant Client
    participant ExtractStatHandler
    participant CollectStatsHandler
    participant DataStore

    Client->>+ExtractStatHandler: Send Heartbeat Request
    ExtractStatHandler->>ExtractStatHandler: Validate Role
    ExtractStatHandler->>+CollectStatsHandler: Forward Heartbeat Request
    CollectStatsHandler->>CollectStatsHandler: Process Statistics
    CollectStatsHandler->>DashMap: Update Cache
    CollectStatsHandler->>DataStore: Persist Stats with PutRequest
    CollectStatsHandler-->>-ExtractStatHandler: Acknowledge Receipt
    ExtractStatHandler-->>-Client: Heartbeat Acknowledged

Poem

In the server's gentle heartbeat thrum, We gather stats, our work begun. Extracts and collects, a cadence bright, Ensuring data feels just right. 🐰✨ With code refined and caches deep, Our meta-service scales to keep.

[!TIP]

Early access features: enabled
We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

fengjiachun commented 4 days ago

@coderabbitai Your summary is not accurate. For example, ExtractStatHandler was not newly introduced; I just renamed it.

coderabbitai[bot] commented 4 days ago

@fengjiachun, thank you for pointing that out. Upon reviewing the git history and diffs, I can confirm that ExtractStatHandler was indeed renamed and not newly introduced. I appreciate your clarification.

Analysis chain

---

Scripts executed

The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Check the git history for the file where `ExtractStatHandler` is mentioned to verify if it was newly created or renamed. git log --follow -- src/meta-srv/src/handler/extract_stat_handler.rs ``` Length of output: 655 --- --- Script: ```shell #!/bin/bash # Check the git diff for the commit where `src/meta-srv/src/handler/extract_stat_handler.rs` was introduced to see if it was renamed or moved from another file. git diff ddc7a80f56885f70e935dd9831aabb9c68d17340 d38d5cd60735b95a432722d5e188f3d3fa13949c ``` Length of output: 22022

Learnings added

``` Learnt from: fengjiachun URL: https://github.com/GreptimeTeam/greptimedb/pull/4236 Timestamp: 2024-07-01T03:08:59.224Z Learning: When summarizing changes, ensure to verify if files or handlers were renamed rather than newly introduced by checking the git history and diffs. ``` > Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure [review instructions](https://docs.coderabbit.ai/guides/review-instructions). You can manage existing learnings in the [app](https://app.coderabbit.ai/learnings).

Actions performed

Summary regeneration triggered.

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 96.39175% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.59%. Comparing base (ddc7a80) to head (36ac0fe). Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4236 +/- ## ========================================== - Coverage 84.86% 84.59% -0.28% ========================================== Files 1045 1046 +1 Lines 184365 184620 +255 ========================================== - Hits 156470 156179 -291 - Misses 27895 28441 +546 ```

GreptimeTeam / greptimedb