search

GreptimeTeam / greptimedb

An open-source, cloud-native, distributed time-series database with PromQL/SQL/Python supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
3.96k stars 282 forks source link

feat!: remove alias `metasrv-addr` #4239

Closed discord9 closed 1 day ago

discord9 commented 3 days ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

https://github.com/GreptimeTeam/greptimedb-operator/pull/156 https://github.com/GreptimeTeam/docs/pull/1030 cherry-pick from https://github.com/GreptimeTeam/greptimedb/pull/4226

What's changed and what's your intention?

remove alias metasrv-addr for metasrv-addrs

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 3 days ago

Walkthrough

The changes across multiple files primarily involve removing aliases from the metasrv_addrs field in the StartCommand struct for both the datanode and frontend components. Additionally, the command line argument for passing server addresses in the Env implementation tests has been updated from --metasrv-addr to --metasrv-addrs.

Changes

Files Change Summary
src/cmd/src/datanode.rs Removed aliases = ["metasrv-addr"] from the metasrv_addrs field's attributes in the StartCommand struct.
src/cmd/src/frontend.rs Removed aliases = ["metasrv-addr"] from the metasrv_addrs field's attributes in the StartCommand struct.
tests/runner/src/env.rs Changed --metasrv-addr to --metasrv-addrs in argument construction within Env implementation tests.

Poem

⚙️🌐

Aliases removed, gone from sight, metasrv_addrs, now just right. Commands refined, so sleek and neat, Addressing servers, a clearer feat.

🐇✨

[!TIP]

AI model upgrade ## `gpt-4o` model for reviews and chat is now live OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide any feedback or to report any issues.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.69%. Comparing base (c4db9e8) to head (632a801).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4239 +/- ## ========================================== - Coverage 84.96% 84.69% -0.28% ========================================== Files 1054 1054 Lines 187160 187160 ========================================== - Hits 159026 158506 -520 - Misses 28134 28654 +520 ```
WenyXu commented 2 days ago

The CI still can't fetch the latest version operator(v0.1.0-alpha.26). cc @daviderli614 @zyy17

Log: 

Release "greptimedb-operator" does not exist. Installing it now.
NAME: greptimedb-operator
LAST DEPLOYED: Wed Jul  3 04:01:17 2024
NAMESPACE: greptimedb-admin
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
***********************************************************************
 Welcome to use greptimedb-operator
 Chart version: 0.1.16
 GreptimeDB Operator version: 0.1.0-alpha.25
***********************************************************************
WenyXu commented 2 days ago

https://github.com/GreptimeTeam/helm-charts/blob/cf2ab450b2cc81aec9682b616944562cd7f78c25/charts/greptimedb-operator/Chart.yaml#L5 Seems we also need to change this?

zyy17 commented 1 day ago

https://github.com/GreptimeTeam/helm-charts/blob/cf2ab450b2cc81aec9682b616944562cd7f78c25/charts/greptimedb-operator/Chart.yaml#L5 Seems we also need to change this?

Let me fix it.