search

GreptimeTeam / greptimedb

An open-source, cloud-native, distributed time-series database with PromQL/SQL/Python supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
3.96k stars 282 forks source link

chore: reduce insertion size of fuzz test #4243

Closed WenyXu closed 2 days ago

WenyXu commented 3 days ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Reduce data insertion size of fuzz_insert & fuzz_insert_logical_table targets.

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 3 days ago

[!WARNING]

Rate limit exceeded

@WenyXu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 5 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 5544797f96c225de8478d04fc44ffe3c74d98c46 and 034c4de6cc1f1091184b3a3ec1bd4baf7e359076.

Walkthrough

The updates primarily involve integrating a new utility function, get_from_env_or_default_value, which fetches configuration values from environment variables or defaults them to predefined values. This function and several associated constants have been employed across various fuzz testing target files to customize parameters such as column and row limits, enhancing flexibility and robustness in fuzz tests' execution.

Changes

Files / Groups Change Summary
tests-fuzz/targets/fuzz_insert.rs Updated imports and added environment-based configuration for column and row limits.
tests-fuzz/targets/fuzz_insert_logical_table.rs Added rows to FuzzInput, environment-based tables, and rows values, and updated insert_values function.
tests-fuzz/targets/fuzz_alter_logical_table.rs Modified imports, added a new utility function and constant, and used them in arbitrary implementation.
tests-fuzz/targets/fuzz_alter_table.rs Changed column generation in generate_create_table_expr to use new utility function and environment variable.
tests-fuzz/targets/fuzz_create_table.rs Added new utility function and constant, updated FuzzInput struct to use environment-based column generation.
tests-fuzz/targets/failover/fuzz_failover_mito_regions.rs Used new utility function for initializing fuzz testing parameters from environment variables.
tests-fuzz/targets/unstable/fuzz_create_table_standalone.rs Updated FuzzInput to include tables field, generated number of tables based on environment variable.

Sequence Diagram(s)

Poem

In the realm of fuzz, where bits do play, We've crafted a tune for variables' sway. With columns and rows from the env they derive, Our tests now dance, alive, alive! Tables and actions, dynamic, robust, In this code-tale, our trust we entrust. 🌟🐇

[!TIP]

Early access features: enabled We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.69%. Comparing base (e531326) to head (034c4de). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4243 +/- ## ========================================== - Coverage 84.84% 84.69% -0.15% ========================================== Files 1049 1054 +5 Lines 186267 186956 +689 ========================================== + Hits 158029 158340 +311 - Misses 28238 28616 +378 ```
fengjiachun commented 2 days ago

Could you explain why we need to reduce the size of data insertion? @WenyXu

killme2008 commented 2 days ago

It's better to be configured by environment variables, and we can configure it larger in release ci and a smaller value for every PR.

killme2008 commented 2 days ago

Could you explain why we need to reduce the size of data insertion? @WenyXu

Just want to speed up the CI.

WenyXu commented 2 days ago

It's better to be configured by environment variables, and we can configure it larger in release ci and a smaller value for every PR.

Good point, I'm going to add this feature.