GreptimeTeam / greptimedb

An open-source, cloud-native, distributed time-series database with PromQL/SQL/Python supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
3.96k stars 282 forks source link

feat: implement naive fuzz test for region migration #4252

Closed WenyXu closed 1 day ago

WenyXu commented 2 days ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  1. Adapt create table generator for new partition rules
  2. Implement naive fuzz test for region migration

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 2 days ago

[!WARNING]

Rate limit exceeded

@WenyXu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 8 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between b9d414def86f4bdc828af30427bce035719f4271 and 3b76af8de5bd49ebf2834ddd59ca57d1948eae9c.

Walkthrough

The changes primarily focus on enhancing fuzz testing functionalities in a database system. New targets for fuzz testing region migration and failover operations were added. Additionally, there’s a refactoring of the partitioning logic and introduction of utilities for region migration and procedure handling. The updates improve the testing of table partitioning, timestamp operations, and region management capabilities.

Changes

File(s) Change Summary
.github/workflows/develop.yml Added new targets "fuzz_migrate_mito_regions" and "fuzz_failover_mito_regions" to workflow matrix configuration.
tests-fuzz/Cargo.toml Added binary configurations for fuzz_migrate_mito_regions and fuzz_failover_mito_regions.
tests-fuzz/src/context.rs Added method timestamp_column to TableContext struct for retrieving the timestamp column.
tests-fuzz/src/generator/create_expr.rs, tests-fuzz/src/translator/mysql/create_expr.rs Refactored partition definitions logic and updated partition expression generation and table options formatting.
tests-fuzz/src/ir.rs, tests-fuzz/src/ir/insert_expr.rs Added functions for generating partition bounds, values, sorting rows, and retrieving column information in InsertIntoExpr struct. Updated timestamp generation logic.
tests-fuzz/src/utils.rs, tests-fuzz/src/utils/migration.rs, tests-fuzz/src/utils/procedure.rs Added migration and procedure modules with functions for region migration, distribution, procedure state fetching, and procedure completion waiting.
tests-fuzz/targets/migration/fuzz_migrate_mito_regions.rs Added functionality for testing region migration in a database system with fuzz testing capabilities.

Sequence Diagram(s)

sequenceDiagram
    participant FuzzTester
    participant MigrationModule
    participant Database

    FuzzTester->>MigrationModule: Invoke migrate_region(from_peer, to_peer)
    MigrationModule->>Database: Execute SQL for region transfer
    Database->>MigrationModule: Return transfer status
    MigrationModule->>FuzzTester: Return migration result

    FuzzTester->>MigrationModule: Wait for region distribution
    MigrationModule->>Database: Check region distribution
    Database->>MigrationModule: Return current distribution
    MigrationModule->>FuzzTester: Return distribution status

Poem

In the realm of data bright, Fuzzing regions takes its flight. Partitions whisper, bounds align, Mitos migrate, procedures refine. New paths usher through code's might, All tested well, from morn to night. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
WenyXu commented 2 days ago

@coderabbitai resolve

coderabbitai[bot] commented 2 days ago
Actions performed Comments resolved.
codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 34.72803% with 156 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (5d396bd) to head (3b76af8). Report is 21 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4252 +/- ## ========================================== - Coverage 84.87% 84.64% -0.23% ========================================== Files 1046 1056 +10 Lines 184619 187319 +2700 ========================================== + Hits 156691 158565 +1874 - Misses 27928 28754 +826 ```