search

GreptimeTeam / greptimedb

An open-source, cloud-native, distributed time-series database with PromQL/SQL/Python supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
3.96k stars 282 forks source link

refactor: Remove the StandaloneKafkaConfig struct #4253

Open irenjj opened 2 days ago

irenjj commented 2 days ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close: #4159

What's changed and what's your intention?

Remove the StandaloneKafkaConfig struct, and replace StandaloneKafkaConfig with DatanodeKafkaConfig.

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 2 days ago

Walkthrough

The changes across multiple files primarily focus on renaming and restructuring configuration structures related to Kafka and WAL (Write-Ahead Logging) setups. Key modifications include replacing the StandaloneWalConfig with DatanodeWalConfig and adding a KafkaTopicConfig struct to centralize Kafka topic configurations. This update standardizes configurations and improves code maintainability by consolidating related settings under a single configuration struct.

Changes

File(s) Change Summary
src/cmd/src/standalone.rs Renamed StandaloneWalConfig to DatanodeWalConfig in various declarations.
src/cmd/tests/load_config_test.rs Replaced StandaloneWalConfig with DatanodeWalConfig in tests.
src/common/wal/src/config.rs Removed StandaloneWalConfig, updated references to DatanodeWalConfig, and modified test cases accordingly.
src/common/wal/src/config/kafka/datanode.rs Added multiple fields to DatanodeKafkaConfig and updated the Default implementation.
src/common/meta/src/wal_options_allocator/... Updated TopicManager implementation to use nested KafkaTopicConfig instead of separate fields.
src/common/wal/src/config/kafka/common.rs Introduced KafkaTopicConfig struct and added fields for topic configurations, including num_topics, selector_type, and more.
src/common/wal/src/config/kafka/metasrv.rs Added KafkaTopicConfig to MetasrvKafkaConfig and removed redundant fields.
config/config.md Renamed Kafka topic configuration keys with a kafka_topic_ prefix.
tests-integration/src/tests/test_util.rs Refactored MetasrvWalConfig initialization to use KafkaTopicConfig.
tests-integration/tests/region_migration.rs Refactored to introduce kafka_topic field in MetasrvKafkaConfig and remove individual topic-related fields.
tests/conf/metasrv-test.toml.template Renamed configuration parameters for Kafka topics, e.g., num_topics to kafka_topic_num_topics.

Sequence Diagram(s)

The requested section is skipped as the changeset does not significantly modify or introduce new control flow mechanisms that necessitate a sequence diagram.

Assessment against linked issues

Objective Addressed Explanation
Remove the StandaloneKafkaConfig struct (#4159) ✅

Poem

In the land of code, changes sweep,
Old configs depart, new ones we keep.
Kafka topics now well-defined,
With DatanodeWalConfig, our code aligned.
Goodbye, Standalone, it's time to part,
Hello, new structure, a fresh start.
📝✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.68%. Comparing base (be29e48) to head (3481f13). Report is 19 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4253 +/- ## ========================================== - Coverage 84.97% 84.68% -0.30% ========================================== Files 1054 1060 +6 Lines 186999 188075 +1076 ========================================== + Hits 158906 159267 +361 - Misses 28093 28808 +715 ```