perf: fine–tuned plan steps

waynexia commented 2 weeks ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

!!! DO NOT LEAVE THIS BLOCK EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Summarize your change (mandatory)
How does this PR work? Need a brief introduction for the changed logic (optional)
Describe clearly one logical change and avoid lazy messages (optional)
Describe any limitations of the current code (optional)

Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

Updates
- Changed repository URLs for dependencies to a new source, ensuring continued integration with updated revisions.
Enhancements
- Improved logical plan optimization for better performance in executing queries.
- Enhanced the physical plan creation process for more efficient query execution.

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The recent changes encompass updating the Cargo.toml file to switch the repository URLs for multiple datafusion dependencies from the Apache repository to waynexia/arrow-datafusion. Additionally, the datafusion.rs and planner.rs files in the src/query/src/dist_plan directory have been modified to enhance the optimization processes for logical plans and to update the handling of Explain plans and MergeScan.

Changes

File	Change Summary
`Cargo.toml`	Changed repository URLs for `datafusion` and related dependencies to `waynexia/arrow-datafusion`.
`src/query/src/datafusion.rs`	Added `MergeScanLogicalPlan` import and modified handling of `Explain` plans and logical plan optimization.
`src/query/src/dist_plan/planner.rs`	Refactored `optimize_input_logical_plan` to optimize directly without explicit `Analyzer` and updated `create_physical_plan`.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant DistExtensionPlanner
    participant SessionState
    participant LogicalPlan
    participant PhysicalPlan

    Client->>DistExtensionPlanner: Call optimize_input_logical_plan
    DistExtensionPlanner->>SessionState: Use session_state
    DistExtensionPlanner->>LogicalPlan: Optimize input logical plan
    LogicalPlan-->>DistExtensionPlanner: Return optimized plan

    Client->>DistExtensionPlanner: Call create_physical_plan
    DistExtensionPlanner->>OptimizedPlan: Use optimized plan
    OptimizedPlan-->>PhysicalPlan: Create physical plan
    PhysicalPlan-->>DistExtensionPlanner: Return physical plan
    DistExtensionPlanner-->>Client: Return result

Poem

In the code, new paths align,
From Apache to Wayne's design,
Optimized with careful thread,
Logical plans now forge ahead.
Arrows in the data's flight,
Merge and scan, our plans delight! 🚀🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.91%. Comparing base (da0c840) to head (adb102f). Report is 5 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4258 +/- ## ========================================== - Coverage 85.18% 84.91% -0.27% ========================================== Files 1060 1060 Lines 189069 189092 +23 ========================================== - Hits 161057 160571 -486 - Misses 28012 28521 +509 ```

GreptimeTeam / greptimedb