GreptimeTeam / greptimedb

An Open-Source, Cloud-Native, Unified Time Series Database for Metrics, Events, and Logs with SQL/PromQL supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
4k stars 289 forks source link

feat: introduce `FlowRouteValue` #4263

Closed WenyXu closed 1 week ago

WenyXu commented 2 weeks ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Introduce FlowRouteValue to store flow routes

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

This update removes the peer_lookup_service across various modules and introduces functionality for managing route information for flows. Significant changes involve the removal of StandalonePeerLookupService and updating key definitions for handling flow routes through new structs and a manager.

Changes

File(s) or Path(s) Change Summary
src/cmd/src/standalone.rs, src/common/meta/src/ddl.rs, src/common/meta/src/ddl_manager.rs Removed peer_lookup_service field and associated references.
src/common/meta/src/key.rs Updated key definitions and added import for FlowRouteValue.
src/common/meta/src/peer.rs Removed StandalonePeerLookupService struct and its implementation.
src/common/meta/src/test_util.rs, tests-integration/src/standalone.rs Removed import and initialization of StandalonePeerLookupService in multiple functions.
src/meta-srv/src/metasrv/builder.rs, src/meta-srv/src/procedure/utils.rs Removed peer_lookup_service from struct initialization.
src/common/meta/src/key/flow/flow_route.rs Introduced new functionality for managing flow route information, including new structs and a manager.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FlowRouteManager
    participant KvBackendRef
    participant Peer

    User->>FlowRouteManager: Retrieve route
    FlowRouteManager->>KvBackendRef: Fetch route from backend
    KvBackendRef-->>FlowRouteManager: Return route data
    FlowRouteManager-->>User: Return flow route

    User->>FlowRouteManager: Create transaction
    FlowRouteManager->>KvBackendRef: Update route in backend
    KvBackendRef-->>FlowRouteManager: Confirm update
    FlowRouteManager-->>User: Transaction successful

Poem

In the code where changes sail, Peer services bid farewell, Routes for flows now charted well, New structs in their tale will tell. 🎉 Changes here, we must regale, With rhythm, rhyme, and an ASCII trail. 🐇✍️


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 92.80303% with 19 lines in your changes missing coverage. Please review.

Project coverage is 84.73%. Comparing base (0f4b9e5) to head (7add345). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4263 +/- ## ========================================== - Coverage 84.97% 84.73% -0.24% ========================================== Files 1054 1055 +1 Lines 187160 187318 +158 ========================================== - Hits 159031 158720 -311 - Misses 28129 28598 +469 ```