Closed WenyXu closed 1 week ago
This update removes the peer_lookup_service
across various modules and introduces functionality for managing route information for flows. Significant changes involve the removal of StandalonePeerLookupService
and updating key definitions for handling flow routes through new structs and a manager.
File(s) or Path(s) | Change Summary |
---|---|
src/cmd/src/standalone.rs , src/common/meta/src/ddl.rs , src/common/meta/src/ddl_manager.rs |
Removed peer_lookup_service field and associated references. |
src/common/meta/src/key.rs |
Updated key definitions and added import for FlowRouteValue . |
src/common/meta/src/peer.rs |
Removed StandalonePeerLookupService struct and its implementation. |
src/common/meta/src/test_util.rs , tests-integration/src/standalone.rs |
Removed import and initialization of StandalonePeerLookupService in multiple functions. |
src/meta-srv/src/metasrv/builder.rs , src/meta-srv/src/procedure/utils.rs |
Removed peer_lookup_service from struct initialization. |
src/common/meta/src/key/flow/flow_route.rs |
Introduced new functionality for managing flow route information, including new structs and a manager. |
sequenceDiagram
participant User
participant FlowRouteManager
participant KvBackendRef
participant Peer
User->>FlowRouteManager: Retrieve route
FlowRouteManager->>KvBackendRef: Fetch route from backend
KvBackendRef-->>FlowRouteManager: Return route data
FlowRouteManager-->>User: Return flow route
User->>FlowRouteManager: Create transaction
FlowRouteManager->>KvBackendRef: Update route in backend
KvBackendRef-->>FlowRouteManager: Confirm update
FlowRouteManager-->>User: Transaction successful
In the code where changes sail, Peer services bid farewell, Routes for flows now charted well, New structs in their tale will tell. 🎉 Changes here, we must regale, With rhythm, rhyme, and an ASCII trail. 🐇✍️
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 92.80303%
with 19 lines
in your changes missing coverage. Please review.
Project coverage is 84.73%. Comparing base (
0f4b9e5
) to head (7add345
). Report is 4 commits behind head on main.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Introduce
FlowRouteValue
to store flow routesChecklist
Summary by CodeRabbit
New Features
Refactor
StandalonePeerLookupService
and associated code from multiple modules, simplifying the codebase.