feat: handle AND/OR and priority in matches fn

waynexia commented 1 week ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

The A in AST is for abstract. So does this patch

Checklist

[x] I have written the necessary rustdoc comments.
[x] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

New Features
- Enhanced pattern matching functionality for more efficient and flexible pattern expressions.
Refactor
- Restructured AST transformation process for improved code readability and maintainability.

coderabbitai[bot] commented 1 week ago

[!NOTE]

Reviews paused

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.

@coderabbitai review to trigger a single review.

Walkthrough

This update implements significant changes in the src/common/function directory. It activates the let_chains feature to utilize more complex control flows in Rust. The alterations in the src/common/function/src/scalars/matches.rs file include modifications to pattern matching and AST transformation processes, enhancing parsing, transforming, and evaluating pattern expressions.

Changes

Files	Summary
`src/common/function/src/lib.rs`	Added `#![feature(let_chains)]` to enable more advanced control flow features in Rust.
`src/common/function/src/scalars/matches.rs`	Added new types and methods, restructured AST transformation, and modified pattern matching logic, including changes in public function declarations and implementation details.

Sequence Diagram(s)

sequenceDiagram
    participant User as User
    participant MatchesFunction as MatchesFunction
    participant PatternAst as PatternAst
    participant ASTTransformer as ASTTransformer

    User->>MatchesFunction: Execute match function
    MatchesFunction->>PatternAst: Parse Pattern Expression
    PatternAst->>ASTTransformer: Initiate transformation process
    ASTTransformer-->>PatternAst: Return transformed AST
    PatternAst-->>MatchesFunction: Transformed AST
    MatchesFunction-->>User: Evaluate and return results

Poem

In the realm of Rust, where logic entwines,
Let chains now enhance as the feature shines.
AST reformed, patterns refined,
Matching expressions, beautifully defined.
With every change, our code aligns.
A rabbit’s delight in improvements combined! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

waynexia commented 1 week ago

@coderabbitai pause

coderabbitai[bot] commented 1 week ago

Actions performed

Reviews paused.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 96.57702% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.68%. Comparing base (ee9a5d7) to head (6e810ac).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4270 +/- ## ========================================== - Coverage 84.94% 84.68% -0.27% ========================================== Files 1057 1057 Lines 187517 187814 +297 ========================================== - Hits 159279 159041 -238 - Misses 28238 28773 +535 ```

waynexia commented 1 week ago

Looks good to me. I have a question: how can we match string literals that are keywords, such as AND and OR? Is there a way to escape them?

quote them should fine. I'll add a test case for this.

GreptimeTeam / greptimedb