Closed evenyag closed 1 week ago
The primary change involves the removal of the prepare_scan_cost
field from various scan-related structs and replacing its usage with query_start.elapsed()
. This includes modifying the locations where scanning costs were previously calculated to use elapsed time directly. Logging updates also reflect these changes, ensuring scan durations are properly tracked and reported.
Files | Change Summary |
---|---|
src/.../scan_region.rs |
Removed prepare_scan_cost field from StreamContext and eliminated its initialization. |
src/.../seq_scan.rs |
Replaced prepare_scan_cost assignments with self.stream_ctx.query_start.elapsed() ; added first_poll variable; updated logs. |
src/.../unordered_scan.rs |
Same changes as in seq_scan.rs , including prepare_scan_cost to query_start.elapsed() replacement, added first_poll , and updated logs. |
src/.../parquet/reader.rs |
Adjusted scan cost calculations; removed elapsed time capture in certain code branches, centralized it. |
In quiet bytes where data streams flow,
Blossoms a change, so calm, so slow.
Away with old costs, elapsed time reigns,
The clock now whispers, progress remains.
Logs now sing in accurate song,
Scan anew, where timings belong.
🌟🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 87.50000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 85.01%. Comparing base (
849e0b9
) to head (a563c3c
). Report is 5 commits behind head on main.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR fixes the scan cost metrics and changes the prepare cost metric. It also logs the elapsed time before the first poll.
Checklist
Summary by CodeRabbit
first_poll
duration).