search

GreptimeTeam / greptimedb

An Open-Source, Cloud-Native, Unified Time Series Database for Metrics, Events, and Logs with SQL/PromQL supported. Available on GreptimeCloud.
https://greptime.com/
Apache License 2.0
4k stars 289 forks source link

feat!: Set merge mode while creating table in influx handler #4299

Closed evenyag closed 1 week ago

evenyag commented 1 week ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR sets the merge_mode to last_non_null for tables created automatically by the influx protocol handler. Now tables created by the influx handler have the same merge mode as measurements in InfluxDB.

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

Recent updates introduce new functions and enums for handling diverse table creation types within the Instance struct in grpc.rs. These changes focus on enhancing row insert handling and table creation with options such as LastNonNull. Key modifications include renaming functions, adding new methods to support specific table types, and updating integration tests to validate new behavior.

Changes

File(s) Change Summary
src/.../grpc.rs Added handle_influx_row_inserts to Instance struct, handling row inserts and delegating last non-null inserts to self.inserter.
src/.../influxdb.rs Renamed handle_row_inserts to handle_influx_row_inserts in InfluxdbLineProtocolHandler for Instance.
src/operator/src/insert.rs Introduced MERGE_MODE_KEY, APPEND_MODE_KEY; new enum AutoCreateTableType; added functions to handle different table creation types and refactored existing ones.
src/store-api/src/mito_engine_options.rs Added public constants APPEND_MODE_KEY and MERGE_MODE_KEY and updated string literals in is_mito_engine_option_key.
tests-integration/src/influxdb.rs Enhanced test scenarios to include CPU data for host2, updated queries, and validated new output.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Instance
    participant Inserter
    participant TableCreator

    Client->>Instance: handle_influx_row_inserts(requests, ctx)
    Instance->>Inserter: handle row inserts
    Inserter->>TableCreator: create_or_alter_table_with_type(LastNonNull)
    TableCreator-->>Inserter: Table creation result
    Inserter-->>Instance: Row Insert result
    Instance-->>Client: Output Result

Poem

In lines of code and bytes of lore,
New tables spring, like fields in yore.
Insert requests now find their way,
Through functions built to save the day.
A rabbit's cheer for changes bright,
New enums, keys, and code so right.
🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
evenyag commented 1 week ago

@coderabbitai summary

coderabbitai[bot] commented 1 week ago
Actions performed Summary regeneration triggered.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 97.22222% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.89%. Comparing base (4f0984c) to head (5476a1e). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4299 +/- ## ========================================== - Coverage 85.25% 84.89% -0.36% ========================================== Files 1058 1060 +2 Lines 186975 187550 +575 ========================================== - Hits 159398 159222 -176 - Misses 27577 28328 +751 ```