fix: support unary operator in default value, partition rule and prepare statement

waynexia commented 1 week ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Closes #4247

What's changed and what's your intention?

Make the unary operator an optional parameter of sql_value_to_value and handle it in several places stated in title.

Checklist

[x] I have written the necessary rustdoc comments.
[x] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

New Features
- Enhanced error handling for unsupported unary operations in SQL statements.
- Improved control flow in SQL value processing to account for unary operations.
Bug Fixes
- Corrected handling of unary operations to ensure accurate error reporting and processing.
Refactor
- Streamlined error types to provide clearer feedback on invalid and unsupported unary operations.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 56.30631% with 97 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (1a9314a) to head (6779ea2). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4301 +/- ## ========================================== - Coverage 85.18% 84.87% -0.32% ========================================== Files 1061 1061 Lines 188392 188586 +194 ========================================== - Hits 160485 160065 -420 - Misses 27907 28521 +614 ```

coderabbitai[bot] commented 1 week ago

Walkthrough

The recent changes enhance error handling and control flow in SQL-related functions, primarily involving unary operators. These improvements introduce specific error types for unary operations, modify function signatures for greater flexibility, and update existing logic to support unary operator handling. The goal is to address partition rule expressions and other scenarios where unary operations are involved.

Changes

File	Change Summary
`src/sql/src/statements.rs`	Enhanced `sql_value_to_value` function for unary operations; added new error types.
`src/operator/src/req_convert/…/stmt_to_region.rs`	Modified `sql_value_to_grpc_value` call to include `None` argument.
`src/sql/src/error.rs`	Added new error variants for unary operators and updated error handling.
`src/sql/src/parsers/create_parser.rs`	Added handling of `Expr::UnaryOp` in `ensure_one_expr` function.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Function
    participant ErrorHandler
    User->>Function: Call sql_value_to_value with unary_op
    Function->>+Logic: Process value with unary_op
    Logic-)Function: Return result or error
    Function->>+ErrorHandler: Handle InvalidUnaryOp or UnsupportedUnaryOp
    ErrorHandler->>User: Return detailed error message

Assessment against linked issues

Objective	Addressed	Explanation
Handle unary operators in SQL error management (#4247)	✅
Ensure `sql_value_to_value` properly processes unary operation expressions (#4247)	✅
Modify function signature to accommodate additional unary operation parameter (#4247)	✅
Recursive handling of unary operations for expression parsing in create_parser (#4247)	✅

Poem

In code we trust, our logic aligned,
Unary operations no longer confined.
Errors will falter, precise and clear,
With each new function, it’s innovation we steer. 🐰✨
Through SQL pathways, our solutions now shine,
GreptimeDB's strength, a testament in time.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

killme2008 commented 1 week ago

@waynexia After rebasing, there is a compile error that needs to be fixed.

GreptimeTeam / greptimedb