Refer to a related PR or issue link (optional)

4017 #3354

What's changed and what's your intention?

Impl show table status [IN database] [LIKE name | WHERE ..].

mysql> show table status\G;
*************************** 1. row ***************************
           Name: numbers
         Engine: test_engine
        Version: 11
     Row_format: Fixed
           Rows: 0
 Avg_row_length: 0
    Data_length: 0
Max_data_length: 0
   Index_length: 0
      Data_free: 0
 Auto_increment: 0
    Create_time: 2024-07-05 23:20:47.992000
    Update_time: NULL
     Check_time: NULL
      Collation: NULL
       Checksum: 0
 Create_options:
        Comment: NULL
1 row in set (0.20 sec)

Fixed the ShowKind display, the All should not display, it's just a placeholder.

Checklist

[x] I have written the necessary rustdoc comments.
[x] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

New Features
- Introduced SHOW TABLE STATUS command to retrieve information about table statuses within the database.
Enhancements
- Improved display logic for various SHOW commands to provide more consistent and clearer output.
Configuration Changes
- Changed default Kafka compression setting from Lz4 to NoCompression for both Datanode and Standalone configurations.
Tests
- Added new test cases for SHOW TABLES LIKE, SHOW FULL TABLES, and SHOW TABLE STATUS commands.

coderabbitai[bot] commented 3 months ago

Walkthrough

The overall changes integrate a new ShowTableStatus feature, modify visibility for an ENGINE constant, refine query output formatting, and update compression settings within kafka configurations. The new ShowTableStatus statements span various files, enhancing SQL parsing, statement execution, and result formatting. These updates enable detailed table status retrieval via SQL, improving database management capabilities.

Changes

Files/Groups	Change Summary
`src/catalog/src/information_schema/tables.rs`	Changed visibility of `ENGINE` constant from private to public.
`src/frontend/src/instance.rs`	Introduced `Statement::ShowTableStatus` case in `check_permission` function.
`src/operator/src/statement` (multiple files)	Added `show_table_status` function and replaced `ShowTables` with `ShowTableStatus`.
`src/query/src/sql.rs`	Added `show_table_status` function and updated `show_tables` to return `Output` if successful.
`src/sql/src/parsers/show_parser.rs`	Added `ShowTableStatus` variant to `Show` enum and implemented parsing logic for `SHOW` statements.
`src/sql/src/statements` (multiple files)	Updated `ShowKind::All` variant, added `format_kind!` macro, and enhanced `Display` implementations.
`tests/cases/standalone/common/show` (multiple files)	Added new queries using `SHOW TABLES LIKE`, `SHOW FULL TABLES`, and `SHOW TABLE STATUS`.
`src/common/wal/src/config.rs`, `src/common/wal/src/config/kafka/*` (multiple files)	Changed compression setting from `Lz4` to `NoCompression`.

Poem

In the codebase, changes bloom, Tables now show their status, room by room. Compression shifts, light as air, Improvements scattered everywhere. 🎉✨ Hopping through lines with cheer, For updates that bring us near. 🚀🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 58.04196% with 60 lines in your changes missing coverage. Please review.

Project coverage is 84.93%. Comparing base (3f4928e) to head (180dda1).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4303 +/- ## ========================================== - Coverage 85.23% 84.93% -0.30% ========================================== Files 1059 1059 Lines 187111 187230 +119 ========================================== - Hits 159480 159020 -460 - Misses 27631 28210 +579 ```

killme2008 commented 3 months ago

I have to revert #4294 , otherwise the sqlness with remote WAL always fails #4304 . @WenyXu

WenyXu commented 3 months ago