coderabbitai[bot]
commented
3 months ago Walkthrough
Incorporated full-text search options and json serialization updates across various modules:
- Enhanced error handling with new error variants.
- Utilized
HashMapandserde_jsonfor managing options. - Updated dependencies within
Cargo.toml. - Introduced a new
Columnstruct and refactored related logic for column operations. - Ensured consistent default values for new
optionsfields across multiple files.
Changes
| File(s) | Change Summary |
|---|---|
| Cargo.toml | Updated greptime-proto dependency, prost.workspace = true and added serde_json as workspace dependency. |
| src/api/src/error.rs | Added SerializeJson error, adjusted error mapping, and imported ColumnDataType. |
| src/api/src/helper.rs, src/common/grpc-expr/src/insert.rs, src/metric-engine/src/... | Added a new options field with default values to various structs. |
| src/api/src/lib.rs | Added #![feature(let_chains)] attribute. |
| src/api/src/v1/column_def.rs | Updated try_as_column_schema for FULLTEXT_GRPC_KEY and added methods for column options and fulltext settings. |
| src/common/grpc-expr/src/error.rs | Introduced UnknownColumnDataType and InvalidFulltextColumnType errors. |
| src/common/meta/src/ddl/test_util/columns.rs | Added options field to ColumnDef struct. |
| src/datatypes/src/schema/column_schema.rs | Renamed FULLTEXT_KEY to FULLTEXT_GRPC_KEY, and added methods for handling fulltext options in ColumnSchema. |
| src/flow/src/adapter/util.rs | Modified column_schemas_to_proto function. |
| src/metric-engine/src/put.rs | Added options: Default::default() to columns in MetricEngineInner implementation. |
| src/mito2/src/request.rs | Added options field to WriteRequest struct initialization. |
| src/mito2/src/test_util.rs, src/operator/src/insert.rs, src/pipeline/tests/... | Added options: None to ColumnSchema struct initializations in various test files. |
| src/operator/src/expr_factory.rs | Removed ColumnDef references, renamed Column to SqlColumn, and adjusted function logic. |
| src/operator/src/req_convert/common.rs | Introduced handling for options in columns_to_rows and column_schema functions. |
| src/operator/src/req_convert/insert/stmt_to_region.rs | Added options field to grpc_column_schema. |
| src/pipeline/src/etl/transform/transformer/greptime/coerce.rs | Introduced HashMap for options and serialization of fulltext options using serde_json. |
| src/pipeline/src/manager/table.rs | Added options: None to ColumnDef instances in PipelineTable implementation. |
| src/sql/src/error.rs | Added FulltextInvalidOption and SetFulltextOption error variants. |
| src/sql/src/statements.rs, src/sql/src/statements/create.rs | Refactored column logic, introduced Column struct, managed nullable columns, and updated tests. |
Sequence Diagram(s)
With these changes being more about data structure and error handling alterations, and not significantly altering the control flow, sequence diagrams are not applicable here.
Poem
Across the code, the changes fly,
Options bloom where once they were shy.
Fulltext fields now doth abound,
Errors clear, more profound.
From humble lines, new features spring,
In Rabbit's realm, improvements sing. 🌟🐰
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
4246
depends on https://github.com/GreptimeTeam/greptime-proto/pull/179
What's changed and what's your intention?
FULLTEXTsyntaxChecklist
Summary by CodeRabbit
New Features
CreateTableandCreateExternalTablestructures with a newColumnstruct to encapsulate column properties.Bug Fixes
Documentation
Refactor
ColumnSchema.