refactor: replace DfLogicalPlan with datafusion_expr::LogicalPlan

sunheyi6 commented 1 month ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

as title, part of https://github.com/GreptimeTeam/greptimedb/issues/3884

What's changed and what's your intention?

As the title said.

Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

Refactor
- Updated module imports to use datafusion_expr::LogicalPlan for improved code maintainability.

coderabbitai[bot] commented 1 month ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes primarily involve updating the import paths for the LogicalPlan from query::plan to datafusion_expr. This update affects several files, including repl.rs, transform.rs, and copy_table_to.rs, signifying a shift in module structure or dependencies to use the datafusion_expr crate.

Changes

File Path	Summary of Changes
`src/cmd/src/cli/repl.rs`	Updated `LogicalPlan` import from `datafusion_expr` and adjusted its usage.
`src/flow/src/transform.rs`	Updated `LogicalPlan` import from `datafusion_expr` and modified references.
`src/operator/src/statement/...`	Updated `LogicalPlan` import from `datafusion_expr` and modified its usage.

Poem

In the land of code, where data flows, A shift in plans, the import shows. From query::plan to datafusion_expr, Our logical paths now freshly confer. With every change, the system grows, As bunnies cheer, the progress glows. 🌟🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

evenyag commented 1 month ago

Thanks for submitting the PR. To remove the wrapper type, we also need to remove the definition of our LogicalPlan and use Datafusion's LogicalPlan directly.

#[derive(Clone, Debug)]
pub enum LogicalPlan {
    DfPlan(DfLogicalPlan),
}

You can refer to https://github.com/GreptimeTeam/greptimedb/pull/3995 which removes the wrapper type for Expr.

killme2008 commented 1 month ago

@sunheyi6 A conflict has to be resolved.

sunheyi6 commented 1 month ago

@sunheyi6 A conflict has to be resolved.

OK, I'll handle it right away.

evenyag commented 1 month ago

Please fix the compiler errors https://github.com/GreptimeTeam/greptimedb/actions/runs/10000323455/job/27646084014?pr=4384

sunheyi6 commented 1 month ago

Please fix the compiler errors https://github.com/GreptimeTeam/greptimedb/actions/runs/10000323455/job/27646084014?pr=4384

ok，i will fix

evenyag commented 1 month ago

https://github.com/GreptimeTeam/greptimedb/blob/main/CONTRIBUTING.md#before-pr Please refer to the contributing guide to run all tests and the clippy check locally first. Also please make sure your code can compile.

GreptimeTeam / greptimedb