Closed zyy17 closed 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 68.08511%
with 15 lines
in your changes missing coverage. Please review.
Project coverage is 84.87%. Comparing base (
0b13ac6
) to head (9b35dff
).
by the way, this doesn't have to be a breaking change. Plugin is not our public API.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
NOTE: The PR will break the
setup_<role>_plugins()
API.Add the
&mut Plugins
argument in the plugins setup API instead of creatingPlugins
inside since we need to add frontend and datanode plugins in standalone mode in onePlugins
;Remove unnecessary
mut
for*Options
I think it's not a good practice to implicitly modify the
*Options
in the plugin setup API. We can modify the*Options
from layered configuration, for example, environment variables, config file, etc;Checklist