perf: Optimizing pipeline performance

paomian commented 1 month ago

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

There are over a thousand lines of code that are test data and benchmarks can be ignored. src/pipeline/benches/data.log is test data. and src/pipeline/benches/processor.rs is benchmark.

Optimizing the performance of type conversions
Use Arc clone instead of String clone
Passing Intermediate State Using Variable References
add an bench
Optimize hash get overconsumption by changing the pipeline's intermediate state to vec
Both timeindex and timestamp are supported to specify the timeindex in the transform.

Original pipeline workflow

pipeline_original

Current pipeline workflow

pipeline_current

In the original method, there is a lot of data allocation and drop, and a lot of hash get operations. By converting the data into a vector, hash get operations are avoided. And the same batch of data share a common intermediate state. After testing, the performance of the same pipeline processing the same data is improved by more than 30%.

Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

coderabbitai[bot] commented 1 month ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 74.52019% with 385 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (216bce6) to head (c34c92f).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4390 +/- ## ========================================== - Coverage 84.95% 84.64% -0.31% ========================================== Files 1091 1091 Lines 194496 195587 +1091 ========================================== + Hits 165229 165559 +330 - Misses 29267 30028 +761 ```

killme2008 commented 1 month ago

I think we must deliver this PR in v0.9.1, so please take a look @sunng87 @shuiyisong @zhongzc

paomian commented 1 month ago

Incompatible changes added

~~Delete date, epoch processor~~
add timestamp process, which is a combination of date and epoch. It can parse time strings as timestamps or treat numbers as timestamps.
~~remove time and epoch from transfrom and replace them with timestmap.~~
~add time index type~ use time replace timestamp index by time

killme2008 commented 1 month ago

Incompatible changes added

Delete date, epoch processor

add timestamp process, which is a combination of date and epoch. It can parse time strings as timestamps or treat numbers as timestamps.

remove time and epoch from transfrom and replace them with timestmap.

add time index type

I don't like breaking changes. You can just deprecate the old processors and remove them from docs.

killme2008 commented 1 month ago

What's the progress of this PR? @shuiyisong @paomian

paomian commented 1 month ago

What's the progress of this PR? @shuiyisong @paomian

There are a few details that need to be changed. Prepare for careful testing.

GreptimeTeam / greptimedb