Alter column option

[killme2008]

What problem does the new feature solve?

since v0.9, GreptimeDB supports full-text index for string columns with the extra fulltext option:

CREATE TABLE `logs` (
  `message` STRING FULLTEXT,
  `time` TIMESTAMP TIME INDEX,
) WITH (
  append_mode = 'true'
);

But if you can't enable an existing string column fulltext option by alter.

What does the feature do?

It already has the modify statement to change the column type:

ALTER TABLE monitor MODIFY COLUMN load_15 STRING;

Supports alter column options just like:

ALTER TABLE monitor SET COLUMN load_15 fulltext WITH(analyzer = 'Chinese', case_sensitive = 'false');

Implementation challenges

No response

[irenjj]

maybe we should first add a new enum member for Kind in greptime-proto for expr_factory to use.

[killme2008]

maybe we should first add a new enum member for Kind in greptime-proto for expr_factory to use.

Yes. A first step.

[WenyXu]

I think ALTER COLUMN(or MODIFY COLUMN) should be better, considering we might have unset operation. @irenjj @killme2008

ALTER TABLE monitor ALTER COLUMN load_15 SET fulltext WITH (analyzer = 'Chinese', case_sensitive = 'false');

ALTER TABLE monitor ALTER COLUMN load_15 UNSET fulltext;

Instead of

ALTER TABLE monitor UNSET COLUMN load_15 fulltext;

[irenjj]

I think ALTER COLUMN(or MODIFY COLUMN) should be better, considering we might have unset operation. @irenjj @killme2008

ALTER TABLE monitor ALTER COLUMN load_15 SET fulltext WITH (analyzer = 'Chinese', case_sensitive = 'false');

ALTER TABLE monitor ALTER COLUMN load_15 UNSET fulltext;

Instead of

ALTER TABLE monitor UNSET COLUMN load_15 fulltext;

I agree.

[killme2008]

Don't add new syntax, keep using modify column [set | unset].