Closed zyy17 closed 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 60.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 84.61%. Comparing base (
7aae19a
) to head (2cab7a5
). Report is 24 commits behind head on main.
Just realized that if user doesn't edit their config toml to remove this mode
, will we throw an error for this "unknown" config item?
If so, this can be a breaking change. Perhaps we can keep it for a minor release and just change the behaviour
Just realized that if user doesn't edit their config toml to remove this
mode
, will we throw an error for this "unknown" config item?If so, this can be a breaking change. Perhaps we can keep it for a minor release and just change the behaviour
Make sense. Let's keep it.
serde typically ignores unknown fields. Do we assert unknown fields to failure anywhere?
serde typically ignores unknown fields. Do we assert unknown fields to failure anywhere?
You are right. @sunng87, the Mode
on the frontend is not always necessary for our released version. When the user uses the current version, they don't need to modify their original config file and don't throw unrecoverable errors.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Resolve https://github.com/GreptimeTeam/greptimedb/issues/4399.
Remove
Mode
fromFrontendOptions
and determine whether it is Standalone or Distributed mode based on whether the Meta Client is configured.Checklist