Closed leaf-potato closed 3 months ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.76%. Comparing base (
49f22f0
) to head (6a396df
). Report is 1 commits behind head on main.
There are some conflicts.
You can merge https://github.com/GreptimeTeam/greptimedb/pull/4414 to this PR to avoid further conflicts between these two PRs.
There are some conflicts.
You can merge #4414 to this PR to avoid further conflicts between these two PRs.
new PR #4426
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
as title, part of https://github.com/GreptimeTeam/greptimedb/issues/3884
What's changed and what's your intention?
Remove PhysicalOptimizer trait and move
optimize_physical_plan
method into DatafusionQueryEngine.Checklist