Closed lyang24 closed 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@lyang24 Hi, there are some CI failures, could you check them?
@lyang24 Hi, there are some CI failures, could you check them?
Yes, ci is green now
@lyang24 Is it ready to review? If it is, I'd like to do it.
@lyang24 Is it ready to review? If it is, I'd like to do it.
Sorry there is one more ci failure and i just pushed an update will let you know once the ci passed
Attention: Patch coverage is 50.00000%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 84.65%. Comparing base (
202c730
) to head (74a945c
). Report is 7 commits behind head on main.
Hey Dennis, I fixed the test failures its ready for review now.
Hey Dennis, I fixed the test failures its ready for review now.
Thank you. Let's review it.
@fengjiachun @sunng87 @MichaelScofield, please help do the review.
@WenyXu PTAL
@lyang24 Thanks a lot. It's a great work!
@lyang24 Would like to add the sample configurations into https://github.com/GreptimeTeam/greptimedb/blob/main/config/metasrv.example.toml
and describe them in the doc https://docs.greptime.com/user-guide/operations/configuration#metasrv-only-configuration ?
@lyang24 Would like to add the sample configurations into https://github.com/GreptimeTeam/greptimedb/blob/main/config/metasrv.example.toml
and describe them in the doc https://docs.greptime.com/user-guide/operations/configuration#metasrv-only-configuration ?
yes will do
This commit implement a postgres backend to persist metasrv's data. A new enum
BackendImpl
with default to etcd was added toMetasrvOptions
to activate postgres backend we could setBackendImpl
to postgres and setstore_addrs
to postgres url.I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
!!! DO NOT LEAVE THIS BLOCK EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist