Closed evenyag closed 2 weeks ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.81%. Comparing base (
22a662f
) to head (1de52c6
). Report is 2 commits behind head on main.
LGTM, but where do you check if a file is expired?
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR fixes that twcs compaction picker may pick expired files to compact.
We already set the
compacting
here: https://github.com/GreptimeTeam/greptimedb/blob/22a662f6bcb811e2c6e36a2a29d035175f4131df/src/mito2/src/compaction/twcs.rs#L218-L222Checklist