search

GreptimeTeam / helm-charts

Helm charts for GreptimeDB.
https://greptimeteam.github.io/helm-charts/
Apache License 2.0
17 stars 6 forks source link

refactor: some scripts directory #159

Closed daviderli614 closed 2 months ago

daviderli614 commented 2 months ago

Refer to https://github.com/GreptimeTeam/greptimedb-operator/pull/168, the greptimedb-operator image tag adds 'v' prefix.

Refactor scripts dir:

scripts/
  crds/
    ...
  e2e/
    ...
  release/
    ...
  update/
    ...

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The recent updates streamline the deployment and testing of greptimedb components. Notable changes include renaming deployment jobs for clarity and switching from script commands to Makefile targets for improved maintainability. The introduction of dedicated E2E testing targets enhances organization and execution. Additionally, the appVersion setting logic has been simplified, resulting in a more consistent and maintainable codebase.

Changes

Files Change Summary
.github/workflows/e2e.yaml Renamed deployment jobs for clarity; replaced script calls with Makefile commands for deployment.
Makefile Added new phony targets for E2E testing; modified existing e2e target; updated comments for version.
scripts/update/update-chart.sh Simplified logic for setting appVersion, removing conditional checks for consistency.
charts/greptimedb-operator/Chart.yaml Updated appVersion and chart version reflecting minor release changes.
charts/greptimedb-operator/README.md Incremented versioning information and image tag for the Helm chart.
charts/greptimedb-operator/templates/crds/*.yaml Added new gcs properties to CRDs for enhanced configuration options with Google Cloud Storage.
charts/greptimedb-operator/values.yaml Updated image tag to reflect the new version.

Poem

🐇 In the meadow, changes bloom,
With clearer jobs, there's more room.
From scripts to Make, so neat and fine,
E2E tests now brightly shine!
Let's hop along, with joy we cheer,
For greptimedb is better, my dear! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
zyy17 commented 2 months ago

@daviderli614 should we trigger a new release of greptimedb-operator to make it work?

daviderli614 commented 2 months ago

@daviderli614 should we trigger a new release of greptimedb-operator to make it work?

@zyy17 Let's release new version v0.1.0-alpha.29 ? https://github.com/GreptimeTeam/greptimedb-operator/releases

zyy17 commented 2 months ago

@daviderli614 should we trigger a new release of greptimedb-operator to make it work?

@zyy17 Let's release new version v0.1.0-alpha.29 ? https://github.com/GreptimeTeam/greptimedb-operator/releases

lgtm

daviderli614 commented 2 months ago

The greptimedb-operator image tag now is v0.1.0-alpha.29.