search

GreycLab / CImg

The CImg Library is a small and open-source C++ toolkit for image processing
http://cimg.eu
Other
1.5k stars 286 forks source link

delete -mtune option on loongarch architecture #321

Closed loongson-zn closed 3 years ago

loongson-zn commented 3 years ago

loongarch64 is a new architecture, currently there is only one cpu, so delete -mtune option

xen0n commented 3 years ago

Hi @loongson-zn, you are putting C preprocessor directives into a Makefile, so I believe the change to be wrong.

I submitted #322 to fix this; you could help test it, as I haven't gotten to verify it myself just yet.

loongson-zn commented 3 years ago

Hi @loongson-zn, you are putting C preprocessor directives into a Makefile, so I believe the change to be wrong.

I submitted #322 to fix this; you could help test it, as I haven't gotten to verify it myself just yet.

@xen0n Thanks for you help. I think your anwser is correct. About #322 , are lines 135-137 accidentally added? Lines 158-163 is correct , I have verified on LoongArch.

loongson-zn commented 3 years ago

Hi @dtschump , I'm sorry for submitting a wrong commit，it's caused by my carelessness. Is it possible to merge #322 to solve such problems( about unrecognized argument in option ‘-mtune=generic’) ?