GreycLab / CImg

The CImg Library is a small and open-source C++ toolkit for image processing
http://cimg.eu
Other
1.46k stars 278 forks source link

Is it really necessary to specify pattern? #412

Closed Reptorian1125 closed 4 months ago

Reptorian1125 commented 5 months ago

Hi, after trying to draw ellipse with 1 px border in G'MIC, I'd have to wonder if it is actually necessary for the user to specify pattern. I'd like to simplify ellipse and likewise command to not need _pattern, and assume that it draws every border.

dtschump commented 5 months ago

Yes, command ellipse actually knows that you want to draw an outline rather than a filled ellipse, specifically because you specify a pattern parameter. For a plain outline, just specify 0xFFFFFFFF as the pattern argument.