search

GreycLab / CImg

The CImg Library is a small and open-source C++ toolkit for image processing
http://cimg.eu
Other
1.49k stars 285 forks source link

Was the v.3.4.0 tag moved? #422

Closed l0b0 closed 3 months ago

l0b0 commented 3 months ago

An automated downstream update picked up a new tag and hash on 2024-06-15T05:22:32Z, but the hash seems to have changed between then and 2024-06-16T08:20:19Z.

dtschump commented 3 months ago

I confirm, I made a mistake. After releasing 3.4.0, I've fixed a minor bug during the week-end, with the idea of building new 3.4.1 pre-release packages. But I call my build script with the wrong parameter (due to the fact that as always, I didn't type the command but searched it in the bash history, forgot about last time was not a pre-release call), thus moving tag 3.4.0. Once the mistake done, I preferred not to touch it again. I promise I won't touch the 3.4.0 tag again from now on : https://github.com/GreycLab/gmic/commit/ac55f66fafbe0aab0ff89ffc51f4287e05949978 Sorry about that.

l0b0 commented 3 months ago

No worries, thanks for confirming! I've gotten into the habit of treating this kind of thing as a possible breach, until confirmed otherwise.

PS: If you avoid -f/--force when tagging it should fail rather than move the tag.

jtojnar commented 3 months ago

You can also disallow force pushing tags using protection rules https://github.com/GreycLab/CImg/settings/rules/new?target=tag. It might be a good idea to enable to prevent this from happening in the future.