GreycLab / gmic

GREYC's Magic for Image Computing: A Full-Featured Open-Source Framework for Image Processing
Other
66 stars 11 forks source link

fx_vibrance doesn't work well on the command line #30

Closed lbalazscs closed 7 months ago

lbalazscs commented 8 months ago

This problem is in version 3.3.2, and can be seen on both Windows and Linux. fx_vibrance works well for negative strength values, but not for positive values. The problem is the worst if the output is a PNG file, for example:

gmic input.png fx_vibrance 1.58 output out.png

I noticed that there seems to be some kind of overflow, and if I add the cut 0,255 command as a second command before creating the output file, then it's OK. Vibrance works well in Gimp, probably because Gimp cuts it automatically.

dtschump commented 8 months ago

Thanks for your report. fx_vibrance does indeed produce out-of-range values, which is not expected. Fix is as you suggested : https://github.com/GreycLab/gmic/commit/af9a872d300f3639213eee0e3d536a70a69106df stdlib and Filters have been updated, so $ gmic update should let you have the fix.

lbalazscs commented 8 months ago

Thank you, it works fine now, after the update!